Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant code #1982

Closed
wants to merge 1 commit into from
Closed

remove redundant code #1982

wants to merge 1 commit into from

Conversation

thiagodebastos
Copy link

@thiagodebastos thiagodebastos commented Apr 6, 2022

This cleans up some unused code, removing a warning that comes up during build of helix source:

helix-term/src/ui/picker.rs

@thiagodebastos
Copy link
Author

Sorry, I am still learning rust. I take it this didn't fail locally because I'm using Rust nightly, and the merged RetainMut is only available on nightly?

@archseer
Copy link
Member

archseer commented Apr 6, 2022

Exactly. It'll be stable in two rust releases (target is 1.61.0 rust-lang/rust@c90a947)

@thiagodebastos
Copy link
Author

thiagodebastos commented Apr 6, 2022

@archseer Fantastic, thanks for clearing that up. Should I then close this PR?

@pickfire
Copy link
Contributor

pickfire commented Apr 7, 2022

@archseer
Copy link
Member

archseer commented Apr 7, 2022

Yeah, we'll patch it when it's available

@archseer archseer closed this Apr 7, 2022
@thiagodebastos
Copy link
Author

Thank you for the feedback guys and thank you for the link @pickfire !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants