Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default development container #2601

Closed
wants to merge 1 commit into from

Conversation

icanhazcheeze
Copy link

When you try GitHub codespaces beta, you start with a default build that doesn't include rustup or cargo. Having a .devcontainer file enables you to have a codespace with rust included in the image.

@icanhazcheeze
Copy link
Author

Oops, quite new to the helix. I also added a commit than enables entering insert mode when you have a series of commands. I didn't intend to push it along with the other commit but forgot to branch before committing.

@the-mikedavis
Copy link
Member

Could you drop out 930b4a5 since it's unrelated?

@the-mikedavis
Copy link
Member

I'm not sure I'm against having a codespaces setup but it does seem odd to have for helix since codespaces tend to promote VS Code. That's not necessarily a bad thing but there is a particular savvy in being able to develop helix using helix

@icanhazcheeze
Copy link
Author

icanhazcheeze commented May 30, 2022

Ok I dropped the other commit from master. Would you be happy to accept it in a different pull request?

@jharrilim jharrilim mentioned this pull request Jun 21, 2022
@the-mikedavis
Copy link
Member

Sorry for the delay. For now we're not interested in having a codespace configuration.

The fix from the dropped commit is being handled in #2634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants