-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right align scrollbar with track in completion popup #2754
Right align scrollbar with track in completion popup #2754
Conversation
I preferred the thinner one! But rendering block chars seems to vary a lot by terminal |
Isn't it possible to use the foreground and background colors of the half-block to fill the gap with the selection color? Or is the background color dictated by the window? |
Got the thin block working without the annoying gap, thanks @CptPotato for the pointer! A new scope Note: The PR now depends on #2728. |
ed3ecd0
to
60779ab
Compare
Looks very clean, I like it! |
Oh yeah the alignment was an off-by-1 error for sure 😆 |
Can you rebase? |
- Align the scollbar to the right edge of the popup rather than at a margin of one. - Add a scrollbar track and a new scope `ui.menu.scroll`.
60779ab
to
9eed490
Compare
Rebased! |
Depends on #2728.
ui.menu.scroll
.A multiline scrollbar like the one mentioned in #2728 (comment) would be nicer though: