DAP: fix serialization of Options
#2959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAP follows the same strict TypeScript interface syntax as LSP which states: > The document uses TypeScript interfaces in strict mode to describe > these. This means for example that a `null` value has to be explicitly > listed and that a mandatory property must be listed even if a falsify > value might exist. So we have to skip serializing any fields that end in `?` instead of passing `null`.
The spec has `cwd` in `RunInTerminalRequestArguments` as non-optional: https://microsoft.github.io/debug-adapter-protocol/specification#Reverse_Requests_RunInTerminal
danyspin97
added a commit
to danyspin97/helix
that referenced
this pull request
Jul 29, 2022
cwd field has been changed in helix-editor#2959 by making it a required field. However, when starting the debugging session, cwd is not set, causing an error in the deserialization part. Manually set cwd to the current directory as a quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAP follows the same strict TypeScript interface syntax as LSP
which states:
So we have to skip serializing any fields that end in
?insteadof passing
null.Also included is a change for a
cwdfield that was in anOptionbut is a required field.More context: erlang-ls/erlang_ls#1346
It looks like lsp-types does the same verbose
#[serde(skip_serializing_if = "Option::is_none")]dance for optional fields: https://github.com/gluon-lang/lsp-types/blob/b26003aa38ad8a996b583de162b66615212b94a3/src/signature_help.rs#L13-L24