Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit theme #3067

Merged
merged 8 commits into from
Oct 3, 2022
Merged

Inherit theme #3067

merged 8 commits into from
Oct 3, 2022

Commits on Aug 9, 2022

  1. Add RawTheme to handle inheritance with theme palette

    @TheSamsa
    TheSamsa committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    33daeaf View commit details
    Browse the repository at this point in the history

  2. Add a intermediate step in theme loading 

    it uses RawTheme struct to load the original ThemePalette, so we can merge it with the inherited one.
    @TheSamsa
    TheSamsa committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    3370de8 View commit details
    Browse the repository at this point in the history

  3. Load default themes via RawThemes, remove Theme deserialization

    @TheSamsa
    TheSamsa committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    cbbe8ae View commit details
    Browse the repository at this point in the history

  4. Allow naming custom theme same as inherited one

    @TheSamsa
    TheSamsa committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    07f6cf2 View commit details
    Browse the repository at this point in the history

  5. Remove RawTheme and use toml::Value directly

    @TheSamsa
    TheSamsa committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    0ddd6d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Resolve all review changes resulting in a cleaner code

    @TheSamsa
    TheSamsa committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    b5e267d View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Simplify return for Loader::load

    @TheSamsa
    TheSamsa committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    43e7cd4 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Add implementation to avoid extra step for loading of base themes

    @TheSamsa
    TheSamsa committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    0bc852b View commit details
    Browse the repository at this point in the history