Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode colors (color-modes) to the "onedark" theme #3098

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

usagi-flow
Copy link
Contributor

After the following themes:

autumn
autumn_night
meliora
night_owl
rose_pine
solarized_dark
solarized_light

...comes onedark!

Regarding the colors (blue for normal, green for insert and purple for selection), I took inspiration from lualine, which uses these colors by default.
Additionally, I find it especially intuitive to have green for insertion (which we know from diffs) and blue for the regular, default state.

I opted for a dark foreground, as a light foreground simply lacks any minimal amount of contrast. A very dark gray ("light-black") seemed to yield the best results.

For those who didn't know yet: This wonderful coloring feature comes from #2676 and must be enabled in the configuration by setting color-modes = true under [editor].

image
image
image

@archseer
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants