Add mode colors (color-modes
) to the "onedark" theme
#3098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the following themes:
...comes onedark!
Regarding the colors (blue for normal, green for insert and purple for selection), I took inspiration from lualine, which uses these colors by default.
Additionally, I find it especially intuitive to have green for insertion (which we know from diffs) and blue for the regular, default state.
I opted for a dark foreground, as a light foreground simply lacks any minimal amount of contrast. A very dark gray ("light-black") seemed to yield the best results.
For those who didn't know yet: This wonderful coloring feature comes from #2676 and must be enabled in the configuration by setting
color-modes = true
under[editor]
.