Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CI builds for
aarch64-macos
#3137Enable CI builds for
aarch64-macos
#3137Changes from 3 commits
b62db50
5cd4d85
fc1c7da
bc5689c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When would
target
be different fromBUILD_TARGET
? Both come fromTARGET
environment variables in build scripts,BUILD_TARGET
from thehelix-loader
crate's build script andtarget
fromhelix-term
'sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
helix_loader::build_grammars
is being used for cross compilation.BUILD_TARGET
represents the target on which the code ofhelix-loader
runs.helix-term
's build script (which hashelix-loader
as build-dependency) needs to usehelix-loader
to cross-compile forhelix-term
's target, which may be different fromBUILD_TARGET
.E.g., when cross-compiling
helix-term
to anaarch64
target on anx86_64
host, two binaries ofhelix-loader
are built:One binary for
aarch64
target for use byhelix-term
's main crate (normal dependency)helix-loader
's build script runs withTARGET = "aarch64"
env!("BUILD_TARGET") = "aarch64"
helix-term
's main crate code passestarget = None
because it wants to compile grammars for the current host =helix-loader
's build targetOne binary for
x86_64
target for use byhelix-term
's build script (build dependency)helix-loader
's build script runs withTARGET = "x86_64"
env!("BUILD_TARGET") = "x86_64"
helix-term
's build script passestarget = "aarch64"
because it wants to cross-compile grammars forhelix-term
's build target, not the host on which the build script runs