Add keybinds for toggling common settings

[the-mikedavis]

hx.mp4

This adds a <space>t binding that can toggle a few select settings:

• visible whitespace
• indent guides
• cursorline
• a ruler at 80

It's has limitations:

• it's not configurable what is toggled¹
• the value of the setting you had before toggling is not possible to restore in all cases without using :set

Closes #2849

Footnotes

1. IMO this should wait for a more general purpose config language. It's possible to do it in TOML but it wouldn't be particularly elegant. It could be pretty elegant to do it if keymaps were written in something like lisp :P ↩

[AlexanderBrevig]

Cool! 👍
I would personally love line number relative toggles.

BTW I restored my config with a simple :config-reload. At first, I thought the toggle would modify my config. Glad that's not the case.

(a lisp for configuration would be awesome)

[AlexanderBrevig]

Very cool! I don't know if it's OK for me to do the review, but here I am anyway :)

[David-Else]

@the-mikedavis Please can we toggle the line numbers on and off? I see this as much more important than line number relative toggles. A perfect solution would be to cycle through all three states with l, is this possible ?

If you are writing docs in markdown you never need line numbers, and even when coding I personally only use line numbers when some legacy linter only gives line numbers of errors, rather than an LSP that can take you right to the problem.

[AlexanderBrevig]

@the-mikedavis Please can we toggle the line numbers on and off? I see this as much more important than line number relative toggles. A perfect solution would be to cycle through all three states with l, is this possible ?

Kind of feels weird with a ternary toggle. Maybe L for on/off and l for absolute/relative?

PS: relative line numbers will make n<operation-that-shifts-vertically> much easier.
You can immediately see that you need to go nC to create n carets for modifying a config file or some such. We all do things differently of course, but this has been a productivity boost for me (yeah, we're measuring sub seconds here 😉)

[David-Else]

Kind of feels weird with a ternary toggle. Maybe L for on/off and l for absolute/relative?

I think it would feel cool and easier to use than L and l, do you think it would be weird as it would be the only ternary and doesn't fit in, or just that toggles should be binary?

[AlexanderBrevig]

Kind of feels weird with a ternary toggle. Maybe L for on/off and l for absolute/relative?

I think it would feel cool and easier to use than L and l, do you think it would be weird as it would be the only ternary and doesn't fit in, or just that toggles should be binary?

After thinking about it more, I think you're right. Probably cool and natural. I'll edit my comment with a strike through.

[the-mikedavis]

I don't have any qualms about this command cycling between a list of options. IMO, if it were configurable then the options would be a list. If visible whitespace had the Selection variant implemented #2208, the toggle would include that. Similar with #3242.

Implementation-wise it's not very clean to disable/enable the line-number gutter because it's controlled by the gutters configuration and not helix_view::editor::LineNumber, so I'd prefer to not add a toggle for it. The use-case of "If you are writing docs in markdown you never need line numbers" sounds like it's somewhat better suited by #3207.

[the-mikedavis]

Despite this working as a proof-of-concept I think it would be better to be able to accomplish this with custom keybinds once there is scripting support / better config.

In the meantime people can use this PR as a guide if they want to build something similar locally