feat(commands) increment by range

[Bruce-Hopkins]

Increment increases the increment amount by 1 (or negative 1) for each value based on issue #3910.

This completely changes the way increment works, so maybe this is better as another command. I don't know what that would be though.

[SoraTenshi]

I think it'd be better to add this functionality into a seperate command, the default behaviour shouldn't be changed for a normal increment, as there a legitimate usecases for it.

also, once the increment counter hit 10+ the results get scewed heavily.

[olafmustafar]

also, once the increment counter hit 10+ the results get scewed heavily.

I believe this issue may be corrected by #4123

[Bruce-Hopkins]

I think it'd be better to add this functionality into a seperate command, the default behaviour shouldn't be changed for a normal increment, as there a legitimate usecases for it.

I agree. I'm trying to figure out which keymap to connect both of them two. Temporarily, I set it to Alt-a. Any suggestions?

I believe this issue may be corrected by #4123

I hope I'm not causing bad merge conflicts.

[SoraTenshi]

Also please update: https://github.com/helix-editor/helix/blob/master/book/src/keymap.md

[SoraTenshi]

Why is this uncommented?

[Omnikar]

A-x is already used for shrink_to_line_bounds.

[Bruce-Hopkins]

A-x is already used for shrink_to_line_bounds.

Do you have any suggestions for a better keymap?

[Bruce-Hopkins]

@CBenoit I've changed the keymappings to be alt+ctrl

is this good to be merged?

[SoraTenshi]

I've changed the keymappings to be alt+ctrl

Is C-A (ctrl + shift) and C-X already reserved / taken? Because i think they'd make more sense...

[Bruce-Hopkins]

Is C-A (ctrl + shift) and C-X already reserved / taken? Because i think they'd make more sense...

I've tried those keymaps but for some reason, they don't work. I'm guessing you can't pair (alt + shift) in the keymaps. Try it out and let me know if it works for you.

[the-mikedavis]

I don't think we implement the # special register from Kakoune yet (https://github.com/mawww/kakoune/blob/master/doc/pages/registers.asciidoc#special-registers) but "#<C-a> and "#<C-x> could be an nice way to do this without needing to add a new command and keybind.

[Bruce-Hopkins]

I don't think we implement the # special register from Kakoune yet (https://github.com/mawww/kakoune/blob/master/doc/pages/registers.asciidoc#special-registers) but "#<C-a> and #<C-x> could be an nice way to do this without needing to add a new command and keybind.

So should we close the PR until the special register is implemented? Or should this just be a temporary fix until then?

[the-mikedavis]

I think it would be ok to kind of hack it in this PR: in increment_impl check the cx.register to see if it's '#' and if it is then increment by range number (multiplied by count?)

[Bruce-Hopkins]

I think it would be ok to kind of hack it in this PR: in increment_impl check the cx.register to see if it's '#' and if it is then increment by range number (multiplied by count?)

Oh, I didn't even know we could see which register we're using. How about this? Does this look good?

[the-mikedavis]

Instead of passing amounts to increase_impl, we can create an enum

enum IncrementDirection {
    Increase,
    Decrease,
}

And pass that to increment_impl, then check the cx.count and cx.register in the body of increment_impl and then decide whether to use a positive or negative amount based on the passed direction.

[Bruce-Hopkins]

Okay, won't we need a 3rd value for the enum if we don't want to increase it at all?

And pass that to increment_impl, then check the cx.count and cx.register in the body of increment_impl and then decide whether to use a positive or negative amount based on the passed direction.

Alright, that makes sense.

[the-mikedavis]

Count can't be 0 so we don't need a third member

[Bruce-Hopkins]

@the-mikedavis How does it look now?

[the-mikedavis]

This is looking good 👍

Just needs a run of cargo fmt

[Bruce-Hopkins]

I just ran the formatter.

[CBenoit]

Thank you! 😄