-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(theme): adjust base16_transparent and dark_high_contrast #5105
Conversation
"diagnostic.debug" ={ fg ="gray", modifiers = ["underlined"] } | ||
"diagnostic.warning" = { fg = "yellow", modifiers = ["underlined"] } | ||
"diagnostic.error" = { fg ="light-red", modifiers = ["underlined"] } | ||
"diagnostic.info" = { underline = { color = "light-blue", style = "dot" } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation is currently incorrect about this underline style, it should be dotted
:
helix/helix-view/src/graphics.rs
Line 323 in f323ffa
"dotted" => Ok(Self::Dotted), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think I mixed that up 😅 I think the documentation was what I originally planning. We use curl
and line
so using the passive dotted
and dashed
seemed inconsistent. Perhaps this should be changed to dashes
and dots
in both documentation and implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they're ok as passive - it makes sense to me as "dotted line" or "dashed line". When in doubt I would say we should follow whatever kitty says they are but it looks like then we would need to change to "curly" too for consistency: https://sw.kovidgoyal.net/kitty/underlines/
I think that just updating the documentation to say "dotted" would be the best choice to minimize breaking changes
underline
instead ofmodifier = ["underlined"]