-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework positioning/rendering and enable softwrap/virtual text #5420
Merged
Commits on Jan 23, 2023
-
rework positioning/rendering, enables softwrap/virtual text
This commit is a large rework of the core text positioning and rendering code in helix to remove the assumption that on-screen columns/lines correspond to text columns/lines. A generic `DocFormatter` is introduced that positions graphemes on and is used both for rendering and for movements/scrolling. Both virtual text support (inline, grapheme overlay and multi-line) and a capable softwrap implementation is included. fix picker highlight cleanup doc formatter, use word bondaries for wrapping make visual vertical movement a seperate commnad estimate line gutter width to improve performance cache cursor position cleanup and optimize doc formatter cleanup documentation fix typos Co-authored-by: Daniel Hines <d4hines@gmail.com> update documentation fix panic in last_visual_line funciton improve soft-wrap documentation add extend_visual_line_up/down commands fix non-visual vertical movement streamline virtual text highlighting, add softwrap indicator fix cursor position if softwrap is disabled improve documentation of text_annotations module avoid crashes if view anchor is out of bounds fix: consider horizontal offset when traslation char_idx -> vpos improve default configuration fix: mixed up horizontal and vertical offset reset view position after config reload apply suggestions from review disabled softwrap for very small screens to avoid endless spin fix wrap_indicator setting fix bar cursor disappearring on the EOF character add keybinding for linewise vertical movement fix: inconsistent gutter highlights improve virtual text API make scope idx lookup more ergonomic allow overlapping overlays correctly track char_pos for virtual text adjust configuration deprecate old position fucntions fix infinite loop in highlight lookup fix gutter style fix formatting document max-line-width interaction with softwrap change wrap-indicator example to use empty string fix: rare panic when view is in invalid state (bis)
Configuration menu - View commit details
-
Copy full SHA for f1791db - Browse repository at this point
Copy the full SHA f1791dbView commit details
Commits on Jan 25, 2023
-
Apply suggestions from code review
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71345e5 - Browse repository at this point
Copy the full SHA 71345e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dbb0bc - Browse repository at this point
Copy the full SHA 3dbb0bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 692bbaa - Browse repository at this point
Copy the full SHA 692bbaaView commit details -
Configuration menu - View commit details
-
Copy full SHA for f743d9a - Browse repository at this point
Copy the full SHA f743d9aView commit details
Commits on Jan 29, 2023
-
Apply suggestions from code review
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d54df49 - Browse repository at this point
Copy the full SHA d54df49View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5d3c4b - Browse repository at this point
Copy the full SHA a5d3c4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ff4750 - Browse repository at this point
Copy the full SHA 9ff4750View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c8faf2 - Browse repository at this point
Copy the full SHA 2c8faf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39f2b4e - Browse repository at this point
Copy the full SHA 39f2b4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d49330 - Browse repository at this point
Copy the full SHA 1d49330View commit details
Commits on Jan 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ed7782d - Browse repository at this point
Copy the full SHA ed7782dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfd5355 - Browse repository at this point
Copy the full SHA bfd5355View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7f6882f - Browse repository at this point
Copy the full SHA 7f6882fView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdac97b - Browse repository at this point
Copy the full SHA cdac97bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d1e53a - Browse repository at this point
Copy the full SHA 5d1e53aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ec785b - Browse repository at this point
Copy the full SHA 1ec785bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.