Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix around-word text-object selection. #546

Merged
merged 5 commits into from
Aug 6, 2021

Conversation

cessen
Copy link
Contributor

@cessen cessen commented Aug 3, 2021

No description provided.

@cessen
Copy link
Contributor Author

cessen commented Aug 3, 2021

I also forgot to update the unit test. Oops!

@sudormrfbin
Copy link
Member

LGTM ! (there's a failing lint for an unused import left)

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not tested but code wise seemed okay.

@cessen
Copy link
Contributor Author

cessen commented Aug 5, 2021

Oops! Making all kinds of mistakes on this PR. Forgot to run clippy. I'll fix the lints.

@cessen
Copy link
Contributor Author

cessen commented Aug 5, 2021

Oops! Making all kinds of mistakes on this PR. Forgot to run clippy. I'll fix the lints.

Apparently I didn't forget. Locally there were no warnings, because it happened due to the auto-rebase to master it was doing here. Just need to rebase to master and fix things up.

@archseer archseer merged commit 953125d into helix-editor:master Aug 6, 2021
@cessen cessen deleted the word_select_fix branch August 6, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants