Fix: white color headers of hx --health
command on light background.
#5543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5516
As said in issue on a light backgrounds white headers (table created with
hx --health
) are almost invisible. Especially with a light theme on gnome-terminal.helix/helix-term/src/health.rs
Lines 161 to 164 in b633139
I thought of 3 possible solutions:
Make the color
Color::Reset
. Then the headings will be the same as thelanguage name
color:First solution + add dashed line after the headings to make it clearer:
Use another color from this list:
But in this case, there is also a possibility that the user is using a background with this color.
What would you recommend?