Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: white color headers of hx --health command on light background. #5543

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 15, 2023

Closes #5516

As said in issue on a light backgrounds white headers (table created with hx --health) are almost invisible. Especially with a light theme on gnome-terminal.

for heading in headings {
column(heading, Color::White);
}
writeln!(stdout)?;

I thought of 3 possible solutions:

  1. Make the color Color::Reset. Then the headings will be the same as the language name color:
    image

  2. First solution + add dashed line after the headings to make it clearer:
    image

  3. Use another color from this list:
    image
    But in this case, there is also a possibility that the user is using a background with this color.

What would you recommend?

Change headers colors to default (RESET). So it looks visible on light themes too.
@ghost ghost closed this by deleting the head repository Jan 16, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column heading of hx --health languages invisible on light terminal theme
1 participant