-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify and clarify config loading #5636
Commits on Aug 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e4873d - Browse repository at this point
Copy the full SHA 4e4873dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e9bee3 - Browse repository at this point
Copy the full SHA 1e9bee3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04da5ee - Browse repository at this point
Copy the full SHA 04da5eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad3fb3 - Browse repository at this point
Copy the full SHA 6ad3fb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a53a008 - Browse repository at this point
Copy the full SHA a53a008View commit details -
Configuration menu - View commit details
-
Copy full SHA for f93e2d1 - Browse repository at this point
Copy the full SHA f93e2d1View commit details
Commits on Sep 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e6e6ec3 - Browse repository at this point
Copy the full SHA e6e6ec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed9aa60 - Browse repository at this point
Copy the full SHA ed9aa60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da3606 - Browse repository at this point
Copy the full SHA 3da3606View commit details
Commits on Sep 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9359c45 - Browse repository at this point
Copy the full SHA 9359c45View commit details
Commits on Sep 19, 2022
-
fix: remove confirm_local_config
Alexander Brevig committedSep 19, 2022 Configuration menu - View commit details
-
Copy full SHA for a0f80cd - Browse repository at this point
Copy the full SHA a0f80cdView commit details
Commits on Sep 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 11aa418 - Browse repository at this point
Copy the full SHA 11aa418View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8acc1b9 - Browse repository at this point
Copy the full SHA 8acc1b9View commit details
Commits on Sep 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0f31164 - Browse repository at this point
Copy the full SHA 0f31164View commit details
Commits on Sep 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 43470cc - Browse repository at this point
Copy the full SHA 43470ccView commit details
Commits on Oct 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 671f297 - Browse repository at this point
Copy the full SHA 671f297View commit details
Commits on Nov 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 84b4f12 - Browse repository at this point
Copy the full SHA 84b4f12View commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 09ea56b - Browse repository at this point
Copy the full SHA 09ea56bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 608687d - Browse repository at this point
Copy the full SHA 608687dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 091b3f5 - Browse repository at this point
Copy the full SHA 091b3f5View commit details -
Simplify labelled command pattern match
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56d624e - Browse repository at this point
Copy the full SHA 56d624eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3642213 - Browse repository at this point
Copy the full SHA 3642213View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7804572 - Browse repository at this point
Copy the full SHA 7804572View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e6c4af - Browse repository at this point
Copy the full SHA 0e6c4afView commit details
Commits on Jan 18, 2023
-
Generalised to multiple runtime directories with priorities
This is an implementation for helix-editor#3346. Previously, one of the following runtime directories were used: 1. `$HELIX_RUNTIME` 2. sibling directory to `$CARGO_MANIFEST_DIR` 3. subdirectory of user config directory 4. subdirectory of path to helix executable The first directory provided / found to exist in this order was used as a root for all runtime file searches (grammars, themes, queries). This change lowers the priority of `$HELIX_RUNTIME` so that the user config runtime has higher priority. More significantly, all of these directories are now searched for runtime files, enabling a user to override default or system-level runtime files. If the same file name appears in multiple runtime directories, the following priority is now used: 1. sibling directory to `$CARGO_MANIFEST_DIR` 2. subdirectory of user config directory 3. `$HELIX_RUNTIME` 4. subdirectory of path to helix executable One exception to this rule is that a user can have a `themes` directory directly in the user config directory that has higher piority to `themes` directories in runtime directories. That behaviour has been preserved. As part of implementing this feature `theme::Loader` was simplified and the cycle detection logic of the theme inheritance was improved to cover more cases and to be more explicit.
Configuration menu - View commit details
-
Copy full SHA for 294d1a1 - Browse repository at this point
Copy the full SHA 294d1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b642e90 - Browse repository at this point
Copy the full SHA b642e90View commit details -
Health displaying ;-separated runtime dirs
Paul Scott committedJan 18, 2023 Configuration menu - View commit details
-
Copy full SHA for c4620ff - Browse repository at this point
Copy the full SHA c4620ffView commit details -
Changed HELIX_RUNTIME build from src instructions
Paul Scott committedJan 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 5a0a1db - Browse repository at this point
Copy the full SHA 5a0a1dbView commit details
Commits on Jan 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6d50d7f - Browse repository at this point
Copy the full SHA 6d50d7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37f49f6 - Browse repository at this point
Copy the full SHA 37f49f6View commit details -
Remove order property of KeyTrie struct:
Was not implemented correctly as the order was in the most cases assigned from the values of an HashMap, which does not guarantee order. This applied to when a keymap was both deserialized and merged. Info box body was then being sorted as a function of the fallacious `order` property, and by a method that yielded at worst a time complexity of at least n^2. Furthermore, the body contents were inerted at first by the order of the hash map keys, in which `order` itself was based on. A more reliable predifined sorting order is to be implemented.
Configuration menu - View commit details
-
Copy full SHA for c748f7c - Browse repository at this point
Copy the full SHA c748f7cView commit details -
Infobox: Remove superflous command descripition pruning:
Exist under the wrong (possibly just outdated) assumption that command descriptions are written with their KeyTrie name prefixed (Space, View, Goto etc.). For examle: The command `file_picker` is assumed to have the description "Space Open file picker", which is not the case , nor for any other command description.
Configuration menu - View commit details
-
Copy full SHA for 2c7c4d9 - Browse repository at this point
Copy the full SHA 2c7c4d9View commit details -
Keymap infobox: Use Vec in place of BTree:
BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.
Configuration menu - View commit details
-
Copy full SHA for 8d35e64 - Browse repository at this point
Copy the full SHA 8d35e64View commit details -
Keymap infobox: Place in correct order from start:
Infobox body was being filled with description then KeyEvent list to only later be iterated over for the purpose of flippingin this order.
Configuration menu - View commit details
-
Copy full SHA for f187f2d - Browse repository at this point
Copy the full SHA f187f2dView commit details -
Keymap infobox: Format body from start
Vec<KeyEvent> was being created as an intermediary into Info.rs for it to be converted into a comma separated string. This commit removes this intermediate step but also the single purpose from_keymap public function in Info.rs, as it is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for 2a0e9d2 - Browse repository at this point
Copy the full SHA 2a0e9d2View commit details -
keymap.rs file splitting, cleanup and descriptive naming:
* Descriptive naming and correct use of data structure terminology example translations: keymap.reverse_map -> keymap.command_list keytrienode -> keytrie (struct) search->traverse merge->merge_keytrie keytrie -> keytrienode (enum describing node variants) Leaf -> MappableCommand Sequence -> CommandSequence Node -> KeyTrie (A leaf is a node, and the sequence was also a node. So old naming made absolutely no sense whatsoever.) * Splitting parts of the keymap.rs file into {keytrienode, keytrie, keymaps, tests}.rs. (Should be self-explanatory by looking at the old keymap.rs.) * Removed KeytrieNode enum functions node(&self) -> Option<&KeyTrie> and node_mut(&mut self) -> Option<&mut KeyTrie> from KeyTrieNode as they served no purpose that could not be used from elsewhere. Was also a bit strange to return a "parent struct" from an enum "building block". * Removed getters that could be achieved by making fields public for now. (E.g .root(), .map(), .name()) * Removed keymap.merge() and keytrienode.merge_nodes() All merging could be handled by keytrie.merge() and keymaps.merge_with_default(), unnecessary to have a second unused system that does about the same thing. We also don't want functions that can cause panics as merge_nodes() could. * Initial simplification and formatting of command palette. Formatting is done during the creation of the command lists, removes the need for the creation and and traversal of an intermediary Vec<Vec<String>>. Keyevent formatting changed from "(<space>w<C-q>)" to ["space>w>C-q"]. Clarifying how commands are triggered by moving through submenus/keytries.
Configuration menu - View commit details
-
Copy full SHA for faec827 - Browse repository at this point
Copy the full SHA faec827View commit details -
Rename MappableCommand field doc to description:
For it not to be confused with the upcoming ":help" feature.
Configuration menu - View commit details
-
Copy full SHA for d5520e8 - Browse repository at this point
Copy the full SHA d5520e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aea10f7 - Browse repository at this point
Copy the full SHA aea10f7View commit details -
Infobox: Consistently place lowercase equivalents first
This, along with previous commit reverts regression in helix-editor#952
Configuration menu - View commit details
-
Copy full SHA for 7f86d01 - Browse repository at this point
Copy the full SHA 7f86d01View commit details -
Remove infobox optimization suggestion comment:
Sort duration calculations averaged to about 0.04 ms when opening the larger infoboxes.
Configuration menu - View commit details
-
Copy full SHA for 7935f77 - Browse repository at this point
Copy the full SHA 7935f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0482d09 - Browse repository at this point
Copy the full SHA 0482d09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b01af5 - Browse repository at this point
Copy the full SHA 6b01af5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a8397c - Browse repository at this point
Copy the full SHA 7a8397cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 546010b - Browse repository at this point
Copy the full SHA 546010bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 036ce4a - Browse repository at this point
Copy the full SHA 036ce4aView commit details -
* Elaborated on test descriptions * Removed duplicate unit test * Unified keytrie traversal in tests
Configuration menu - View commit details
-
Copy full SHA for ac98d82 - Browse repository at this point
Copy the full SHA ac98d82View commit details -
Load keymap config consistently
* Moved config merging Keymaps to Config * Removed unused default EditorView function
Configuration menu - View commit details
-
Copy full SHA for 109228b - Browse repository at this point
Copy the full SHA 109228bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 527198a - Browse repository at this point
Copy the full SHA 527198aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 917ca0d - Browse repository at this point
Copy the full SHA 917ca0dView commit details -
Renamed the keymap! macro to keytrie!:
It produces, after all, a Keytrie. It would be a bit like saying: let engine = car!()
Configuration menu - View commit details
-
Copy full SHA for 8b8fadb - Browse repository at this point
Copy the full SHA 8b8fadbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7747777 - Browse repository at this point
Copy the full SHA 7747777View commit details -
By the end of this refactroring it became clear that it was mostly acting as a useless wrapper for KeyTrie.
Configuration menu - View commit details
-
Copy full SHA for 342f794 - Browse repository at this point
Copy the full SHA 342f794View commit details -
Switched keymap::keymaps::Keymaps to keymap::Keymap
Root keymap module was empty as old Keymap could be removed. And there was no point anymore in differentiating Keymaps and Keymap.
Configuration menu - View commit details
-
Copy full SHA for 020c53a - Browse repository at this point
Copy the full SHA 020c53aView commit details -
Re-implemented pre-defined orders in keytrie
* Fixed aliased_modes_are_same_in_default_keymap to check for order too. It failed to detect a bug in which the swap_view_* were ordered differently under space-w and c-w.
Configuration menu - View commit details
-
Copy full SHA for bda06bc - Browse repository at this point
Copy the full SHA bda06bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87fc571 - Browse repository at this point
Copy the full SHA 87fc571View commit details -
Sorts by modifier, then by KeyCode category, then by each KeyEvent. Single character alphas are placed before the rest (ex. "space") in KeyCode::Char.
Configuration menu - View commit details
-
Copy full SHA for ecf5d61 - Browse repository at this point
Copy the full SHA ecf5d61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e7f4a0 - Browse repository at this point
Copy the full SHA 5e7f4a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c88a817 - Browse repository at this point
Copy the full SHA c88a817View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f0fa30 - Browse repository at this point
Copy the full SHA 2f0fa30View commit details -
Configuration -> LanguageConfigurations
* Renamed helix_core::syntax::Configuration to LanguageConfigurations to dinstiuish it from the other types of configurations (theme, keys, editor...), and to illustate that it is actually a collection of LanguageConfigurations * (Would similarly want the the LanguagesConfiguarions field 'language' was renamed to 'language_configurations' but that wold interfere with the languages.toml file.
Configuration menu - View commit details
-
Copy full SHA for f3de1fb - Browse repository at this point
Copy the full SHA f3de1fbView commit details -
user_lang_config -> merged_lang_config
* Renamed user_lang_config to merged_lang_config, as it includes the default language config.
Configuration menu - View commit details
-
Copy full SHA for 55fb3e1 - Browse repository at this point
Copy the full SHA 55fb3e1View commit details -
Enforce separation of concerns in config loading
* Moved the functions of helix_loader::config (relate only to langage config) to helix-loader/lib.rs, and removed the file. Mostly to aid in comparison in how the config is loaded. * Moved the functions of helix_core::config to helix_core::syntax. This way they're loaded the same way as the config.toml. Forces a consistency initialsing language config with LanguageConfigurations::default() and ::merged() respectively. helix_core::config.rs was then removed.
Configuration menu - View commit details
-
Copy full SHA for 34f4380 - Browse repository at this point
Copy the full SHA 34f4380View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3ec215 - Browse repository at this point
Copy the full SHA e3ec215View commit details -
Configuration menu - View commit details
-
Copy full SHA for cab5aac - Browse repository at this point
Copy the full SHA cab5aacView commit details -
Fix error prone config setup in main
* Removed config dir check and creation from helix-term main.rs, it was being done in the proceeding line with helix_loader::initialize_config_file() * Log path setup moved to helix_loader, and setup not done before setting up logging. It would create the default log folder even if user specifies thier own log file. * Fixed helix_loader::config_file() and log_file() assumption of existing parent directory.
Configuration menu - View commit details
-
Copy full SHA for 88bd9cc - Browse repository at this point
Copy the full SHA 88bd9ccView commit details -
Return Ok(0) to main instead of directly doing process::exit(0) on only some of the args. Makes it easier to implement special exit handling before quitting.
Configuration menu - View commit details
-
Copy full SHA for 11248c1 - Browse repository at this point
Copy the full SHA 11248c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cd0042 - Browse repository at this point
Copy the full SHA 3cd0042View commit details -
X Setup coherent config loading API
Does not put project in working state, rebase with helix-editor#5635
Configuration menu - View commit details
-
Copy full SHA for 8c5700d - Browse repository at this point
Copy the full SHA 8c5700dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c49ad - Browse repository at this point
Copy the full SHA e6c49adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dfe855 - Browse repository at this point
Copy the full SHA 1dfe855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d52c7a - Browse repository at this point
Copy the full SHA 3d52c7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55a64f8 - Browse repository at this point
Copy the full SHA 55a64f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1eaaf2d - Browse repository at this point
Copy the full SHA 1eaaf2dView commit details -
* RUNTIME_DIR now behaves similar to the other runtime files * merge_toml_values: Moved function explanation comment in a function call to its documentation.
Configuration menu - View commit details
-
Copy full SHA for 6aec856 - Browse repository at this point
Copy the full SHA 6aec856View commit details -
Unify tasks from xtask and helix_loader
* Wider use relative path replacements by moving xtask::pash to helix_loader::repo_paths.rs. * Wider use of new LanguageConfig load API * Minor appalication.rs cleanup
Configuration menu - View commit details
-
Copy full SHA for 5331bb6 - Browse repository at this point
Copy the full SHA 5331bb6View commit details -
Use unified config loading in docgen and health
health.rs * Removed duplicate clipboard provider writeout. * Removed 'all' flag option but added a 'paths' option. * Removed check if user config exist or show default part as default is always merged with user config. docgen: * removed xtask::helper::lang_config(), using LanguageConfiguarions::default() instead. * moved xtask::query_check to xtask::main and made it use TSFeature.runtime_filename()
Configuration menu - View commit details
-
Copy full SHA for 3be034c - Browse repository at this point
Copy the full SHA 3be034cView commit details
Commits on Jan 23, 2023
-
Merge remote-tracking branch 'brevig-local-config/feat-load-local-con…
…fig' into unify-config
Configuration menu - View commit details
-
Copy full SHA for b9b916d - Browse repository at this point
Copy the full SHA b9b916dView commit details -
* Fix failing integration testing * Fix bug in which which local directories were being tested for their existence. * Fixes helix-editor#5144 * Ran cargo fmt
Configuration menu - View commit details
-
Copy full SHA for d814356 - Browse repository at this point
Copy the full SHA d814356View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae6790c - Browse repository at this point
Copy the full SHA ae6790cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44ad646 - Browse repository at this point
Copy the full SHA 44ad646View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaea712 - Browse repository at this point
Copy the full SHA eaea712View commit details -
Configuration menu - View commit details
-
Copy full SHA for abf2f28 - Browse repository at this point
Copy the full SHA abf2f28View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae26ae - Browse repository at this point
Copy the full SHA bae26aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for eccda6e - Browse repository at this point
Copy the full SHA eccda6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 64cefce - Browse repository at this point
Copy the full SHA 64cefceView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcf3cb0 - Browse repository at this point
Copy the full SHA bcf3cb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2afcfcf - Browse repository at this point
Copy the full SHA 2afcfcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8affcc - Browse repository at this point
Copy the full SHA b8affccView commit details
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c617fd1 - Browse repository at this point
Copy the full SHA c617fd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cac825 - Browse repository at this point
Copy the full SHA 3cac825View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dbacf3 - Browse repository at this point
Copy the full SHA 7dbacf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d02459 - Browse repository at this point
Copy the full SHA 4d02459View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3dd261 - Browse repository at this point
Copy the full SHA e3dd261View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4b82b4 - Browse repository at this point
Copy the full SHA b4b82b4View commit details -
Merge branch 'keymap-presentation' of https://github.com/gibbz00/helix …
…into keymap-presentation
Configuration menu - View commit details
-
Copy full SHA for 8c1333a - Browse repository at this point
Copy the full SHA 8c1333aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58a9cad - Browse repository at this point
Copy the full SHA 58a9cadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f760f1 - Browse repository at this point
Copy the full SHA 3f760f1View commit details -
Reduced comment some verbosity, the method signatures should speak for themselves. runtime_file -> get_runtime_file
Configuration menu - View commit details
-
Copy full SHA for 90926bb - Browse repository at this point
Copy the full SHA 90926bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d463f1 - Browse repository at this point
Copy the full SHA 2d463f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2afd72 - Browse repository at this point
Copy the full SHA f2afd72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f966d7 - Browse repository at this point
Copy the full SHA 1f966d7View commit details -
* Clarify method signature of newly intrudused path -> find_remaining_path * Remove unused self.names() * Removed overly verbose comments.
Configuration menu - View commit details
-
Copy full SHA for 0b9c2e8 - Browse repository at this point
Copy the full SHA 0b9c2e8View commit details -
Create helix_loader::get_first_runtime_dir
Replaces the get_runtime_dirs().first().expect("...") in helix_loader:::grammar
Configuration menu - View commit details
-
Copy full SHA for e7aee35 - Browse repository at this point
Copy the full SHA e7aee35View commit details
Commits on Jan 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8dd563 - Browse repository at this point
Copy the full SHA c8dd563View commit details -
Configuration menu - View commit details
-
Copy full SHA for df49f60 - Browse repository at this point
Copy the full SHA df49f60View commit details -
Remove order property of KeyTrie struct:
Was not implemented correctly as the order was in the most cases assigned from the values of an HashMap, which does not guarantee order. This applied to when a keymap was both deserialized and merged. Info box body was then being sorted as a function of the fallacious `order` property, and by a method that yielded at worst a time complexity of at least n^2. Furthermore, the body contents were inerted at first by the order of the hash map keys, in which `order` itself was based on. A more reliable predifined sorting order is to be implemented.
Configuration menu - View commit details
-
Copy full SHA for 69ed135 - Browse repository at this point
Copy the full SHA 69ed135View commit details -
Infobox: Remove superflous command descripition pruning:
Exist under the wrong (possibly just outdated) assumption that command descriptions are written with their KeyTrie name prefixed (Space, View, Goto etc.). For examle: The command `file_picker` is assumed to have the description "Space Open file picker", which is not the case , nor for any other command description.
Configuration menu - View commit details
-
Copy full SHA for 10151a9 - Browse repository at this point
Copy the full SHA 10151a9View commit details -
Keymap infobox: Use Vec in place of BTree:
BTree was being used to store a list of keyevents for a given command. This list was only iterated over twice to in the end be converted to a Vec. Better to just use a Vec from start given the use- case. Temporalily reverts helix-editor#952.
Configuration menu - View commit details
-
Copy full SHA for 465c0ef - Browse repository at this point
Copy the full SHA 465c0efView commit details -
Keymap infobox: Place in correct order from start:
Infobox body was being filled with description then KeyEvent list to only later be iterated over for the purpose of flippingin this order.
Configuration menu - View commit details
-
Copy full SHA for 8768bf9 - Browse repository at this point
Copy the full SHA 8768bf9View commit details -
Keymap infobox: Format body from start
Vec<KeyEvent> was being created as an intermediary into Info.rs for it to be converted into a comma separated string. This commit removes this intermediate step but also the single purpose from_keymap public function in Info.rs, as it is no longer needed.
Configuration menu - View commit details
-
Copy full SHA for b50050b - Browse repository at this point
Copy the full SHA b50050bView commit details -
keymap.rs file splitting, cleanup and descriptive naming:
* Descriptive naming and correct use of data structure terminology example translations: keymap.reverse_map -> keymap.command_list keytrienode -> keytrie (struct) search->traverse merge->merge_keytrie keytrie -> keytrienode (enum describing node variants) Leaf -> MappableCommand Sequence -> CommandSequence Node -> KeyTrie (A leaf is a node, and the sequence was also a node. So old naming made absolutely no sense whatsoever.) * Splitting parts of the keymap.rs file into {keytrienode, keytrie, keymaps, tests}.rs. (Should be self-explanatory by looking at the old keymap.rs.) * Removed KeytrieNode enum functions node(&self) -> Option<&KeyTrie> and node_mut(&mut self) -> Option<&mut KeyTrie> from KeyTrieNode as they served no purpose that could not be used from elsewhere. Was also a bit strange to return a "parent struct" from an enum "building block". * Removed getters that could be achieved by making fields public for now. (E.g .root(), .map(), .name()) * Removed keymap.merge() and keytrienode.merge_nodes() All merging could be handled by keytrie.merge() and keymaps.merge_with_default(), unnecessary to have a second unused system that does about the same thing. We also don't want functions that can cause panics as merge_nodes() could. * Initial simplification and formatting of command palette. Formatting is done during the creation of the command lists, removes the need for the creation and and traversal of an intermediary Vec<Vec<String>>. Keyevent formatting changed from "(<space>w<C-q>)" to ["space>w>C-q"]. Clarifying how commands are triggered by moving through submenus/keytries.
Configuration menu - View commit details
-
Copy full SHA for eb50de1 - Browse repository at this point
Copy the full SHA eb50de1View commit details -
Rename MappableCommand field doc to description:
For it not to be confused with the upcoming ":help" feature.
Configuration menu - View commit details
-
Copy full SHA for d74be02 - Browse repository at this point
Copy the full SHA d74be02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7192a4e - Browse repository at this point
Copy the full SHA 7192a4eView commit details -
Infobox: Consistently place lowercase equivalents first
This, along with previous commit reverts regression in helix-editor#952
Configuration menu - View commit details
-
Copy full SHA for 26adc32 - Browse repository at this point
Copy the full SHA 26adc32View commit details -
Remove infobox optimization suggestion comment:
Sort duration calculations averaged to about 0.04 ms when opening the larger infoboxes.
Configuration menu - View commit details
-
Copy full SHA for 4fb58f7 - Browse repository at this point
Copy the full SHA 4fb58f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d33ff8b - Browse repository at this point
Copy the full SHA d33ff8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 958e8bc - Browse repository at this point
Copy the full SHA 958e8bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f93ec - Browse repository at this point
Copy the full SHA d0f93ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 876885e - Browse repository at this point
Copy the full SHA 876885eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 315fa89 - Browse repository at this point
Copy the full SHA 315fa89View commit details -
* Elaborated on test descriptions * Removed duplicate unit test * Unified keytrie traversal in tests
Configuration menu - View commit details
-
Copy full SHA for fcf8e6b - Browse repository at this point
Copy the full SHA fcf8e6bView commit details -
Load keymap config consistently
* Moved config merging Keymaps to Config * Removed unused default EditorView function
Configuration menu - View commit details
-
Copy full SHA for e233a1b - Browse repository at this point
Copy the full SHA e233a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a188d2 - Browse repository at this point
Copy the full SHA 4a188d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for baf8640 - Browse repository at this point
Copy the full SHA baf8640View commit details -
Renamed the keymap! macro to keytrie!:
It produces, after all, a Keytrie. It would be a bit like saying: let engine = car!()
Configuration menu - View commit details
-
Copy full SHA for 3466209 - Browse repository at this point
Copy the full SHA 3466209View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff25380 - Browse repository at this point
Copy the full SHA ff25380View commit details -
By the end of this refactroring it became clear that it was mostly acting as a useless wrapper for KeyTrie.
Configuration menu - View commit details
-
Copy full SHA for 5c6c0ed - Browse repository at this point
Copy the full SHA 5c6c0edView commit details -
Switched keymap::keymaps::Keymaps to keymap::Keymap
Root keymap module was empty as old Keymap could be removed. And there was no point anymore in differentiating Keymaps and Keymap.
Configuration menu - View commit details
-
Copy full SHA for ff6b53f - Browse repository at this point
Copy the full SHA ff6b53fView commit details -
Re-implemented pre-defined orders in keytrie
* Fixed aliased_modes_are_same_in_default_keymap to check for order too. It failed to detect a bug in which the swap_view_* were ordered differently under space-w and c-w.
Configuration menu - View commit details
-
Copy full SHA for aed2e90 - Browse repository at this point
Copy the full SHA aed2e90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5edce2e - Browse repository at this point
Copy the full SHA 5edce2eView commit details -
Sorts by modifier, then by KeyCode category, then by each KeyEvent. Single character alphas are placed before the rest (ex. "space") in KeyCode::Char.
Configuration menu - View commit details
-
Copy full SHA for 0b08e38 - Browse repository at this point
Copy the full SHA 0b08e38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5049e7c - Browse repository at this point
Copy the full SHA 5049e7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f758ee - Browse repository at this point
Copy the full SHA 4f758eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c224bf3 - Browse repository at this point
Copy the full SHA c224bf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a2b87 - Browse repository at this point
Copy the full SHA 95a2b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 941624b - Browse repository at this point
Copy the full SHA 941624bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7735b34 - Browse repository at this point
Copy the full SHA 7735b34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e1a3da - Browse repository at this point
Copy the full SHA 8e1a3daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e2d74 - Browse repository at this point
Copy the full SHA 16e2d74View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc8e463 - Browse repository at this point
Copy the full SHA dc8e463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bfa470 - Browse repository at this point
Copy the full SHA 4bfa470View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03088b2 - Browse repository at this point
Copy the full SHA 03088b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf9f82 - Browse repository at this point
Copy the full SHA 4bf9f82View commit details -
Merge branch 'keymap-presentation' of https://github.com/gibbz00/helix …
…into keymap-presentation
Configuration menu - View commit details
-
Copy full SHA for eaf883b - Browse repository at this point
Copy the full SHA eaf883bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 89936e1 - Browse repository at this point
Copy the full SHA 89936e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 816a9dd - Browse repository at this point
Copy the full SHA 816a9ddView commit details -
Proper runtime directory health diagnostics
Instead of blurting out, say "does not exist", without refererring to which directory the diagnostic relates to.
Configuration menu - View commit details
-
Copy full SHA for eb31bd7 - Browse repository at this point
Copy the full SHA eb31bd7View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa615c2 - Browse repository at this point
Copy the full SHA fa615c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4af3d1d - Browse repository at this point
Copy the full SHA 4af3d1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13a9f3e - Browse repository at this point
Copy the full SHA 13a9f3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b27f4a5 - Browse repository at this point
Copy the full SHA b27f4a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5e505e - Browse repository at this point
Copy the full SHA c5e505eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dd2169 - Browse repository at this point
Copy the full SHA 8dd2169View commit details -
Scrapped FromIterator<InfoboxRow> idea
Removes the ability to create the Vec using with_capacity if I'm not mistaken.
Configuration menu - View commit details
-
Copy full SHA for b8e1ee4 - Browse repository at this point
Copy the full SHA b8e1ee4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 375238f - Browse repository at this point
Copy the full SHA 375238fView commit details
Commits on Jan 26, 2023
-
This adds a new output to --health that displays the formatter binary.
Configuration menu - View commit details
-
Copy full SHA for dc06713 - Browse repository at this point
Copy the full SHA dc06713View commit details
Commits on Feb 12, 2023
-
Add prefix position to file args
A cursor position can now be specified using common prefix notation used by vim, nvim, kak, emacs and nano. eg. `hx +10 Cargo.toml` This prefix notation also allows the user to set the cursor at the end of the file. eg. `hx +: Cargo.toml` This allows `hx` to play nicely with other tools that want to open a file at a given position using prefix notation. The existing postfix notation can still be used (`hx Cargo.toml:10`) but has been extended to support jumping to the end of a buffer. eg. `hx Cargo.toml:`
Configuration menu - View commit details
-
Copy full SHA for 1e6c605 - Browse repository at this point
Copy the full SHA 1e6c605View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a75108 - Browse repository at this point
Copy the full SHA 0a75108View commit details -
Configuration menu - View commit details
-
Copy full SHA for 461e31f - Browse repository at this point
Copy the full SHA 461e31fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 22e491e - Browse repository at this point
Copy the full SHA 22e491eView commit details
Commits on Feb 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 872f01f - Browse repository at this point
Copy the full SHA 872f01fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0622cdc - Browse repository at this point
Copy the full SHA 0622cdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34ab790 - Browse repository at this point
Copy the full SHA 34ab790View commit details -
Configuration menu - View commit details
-
Copy full SHA for e480a16 - Browse repository at this point
Copy the full SHA e480a16View commit details -
Merge 'matt-cheely/labels-for-config-menus'
Changes: Makes it possible to also add custom descriptions of CommandSequences, not only KeyTries and Typable commands. Test have been added for each case. Also, if no arguments are passed to the typaple command, use official description. (instead of say :w). Uses the term description instead of label for consistencies sake. "description" key is followed by "exec" for command sequences and mappable commands in TOML config.
Configuration menu - View commit details
-
Copy full SHA for 8d4626c - Browse repository at this point
Copy the full SHA 8d4626cView commit details -
Merge branch 'master' of https://github.com/helix-editor/helix into k…
…eymap-presentation
Configuration menu - View commit details
-
Copy full SHA for a7abb1f - Browse repository at this point
Copy the full SHA a7abb1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 395bfa6 - Browse repository at this point
Copy the full SHA 395bfa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b06eb3f - Browse repository at this point
Copy the full SHA b06eb3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0756dd5 - Browse repository at this point
Copy the full SHA 0756dd5View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 56189c9 - Browse repository at this point
Copy the full SHA 56189c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f44a348 - Browse repository at this point
Copy the full SHA f44a348View commit details -
Configuration menu - View commit details
-
Copy full SHA for b62d9a4 - Browse repository at this point
Copy the full SHA b62d9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9825ca0 - Browse repository at this point
Copy the full SHA 9825ca0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 044e344 - Browse repository at this point
Copy the full SHA 044e344View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcbae4b - Browse repository at this point
Copy the full SHA fcbae4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b69a7d4 - Browse repository at this point
Copy the full SHA b69a7d4View commit details -
args.rs: move PositionRequest for file readability
* Moved some helper functions to become associated functins of PositionRequest. * Increased usage of Self. * Moved PositionRequest logic and tests into it's one file.
Configuration menu - View commit details
-
Copy full SHA for 2665ae8 - Browse repository at this point
Copy the full SHA 2665ae8View commit details -
load-local-config set to false by default
Otherwise it becomes impossible to run `hx -c /dev/null`
Configuration menu - View commit details
-
Copy full SHA for 7b5b268 - Browse repository at this point
Copy the full SHA 7b5b268View commit details
Commits on Feb 15, 2023
-
Merge 'bbodi/sticky-config/sticky-config'
Does not work with pre-existing keytrienodes... Will try to check if it work on the unify-config branch as I suspect config loading might be the culprit.
Configuration menu - View commit details
-
Copy full SHA for b609a02 - Browse repository at this point
Copy the full SHA b609a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for c36ba42 - Browse repository at this point
Copy the full SHA c36ba42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72e1581 - Browse repository at this point
Copy the full SHA 72e1581View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9bc2a - Browse repository at this point
Copy the full SHA ad9bc2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34db341 - Browse repository at this point
Copy the full SHA 34db341View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d9cea8 - Browse repository at this point
Copy the full SHA 2d9cea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68c66ac - Browse repository at this point
Copy the full SHA 68c66acView commit details -
fix keytrie on default mappable command override bug
I had introduced a bug in which it wasn't possible to override mappable commands with keytries. Test has been added to catch this miss.
Configuration menu - View commit details
-
Copy full SHA for 6a81215 - Browse repository at this point
Copy the full SHA 6a81215View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91d8d92 - Browse repository at this point
Copy the full SHA 91d8d92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 159150b - Browse repository at this point
Copy the full SHA 159150bView commit details -
revert some cleanup of use statements
...in the hopes that it simplifies review. The changes should have probably be codified into `cargo fmt`.
Configuration menu - View commit details
-
Copy full SHA for 683931a - Browse repository at this point
Copy the full SHA 683931aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec76a96 - Browse repository at this point
Copy the full SHA ec76a96View commit details -
improve keymap deserialize error handlig
Replace two `.expect()` with returning Err. Using the let else pattern for this. Only became stable in 1.65.0, hence the bump.
Configuration menu - View commit details
-
Copy full SHA for e98afd2 - Browse repository at this point
Copy the full SHA e98afd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a06115 - Browse repository at this point
Copy the full SHA 3a06115View commit details -
Probably introduced when merging with helix-editor#3207. Refreshing config from failed state would not update to set theme from default theme. Reason being that theme was being loaded before config was being set. One would have to refresh the config twice to update the theme as well. This commit changes the refresh order such that the config is actually set before refreshing the theme.
Configuration menu - View commit details
-
Copy full SHA for 27c45ba - Browse repository at this point
Copy the full SHA 27c45baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f3d102e - Browse repository at this point
Copy the full SHA f3d102eView commit details -
* theme_loader in editor only * consistent use of lang_configs_loader
Configuration menu - View commit details
-
Copy full SHA for fcd8b31 - Browse repository at this point
Copy the full SHA fcd8b31View commit details -
Arcswap for theme_loader can now be removed as Editor is it's sole owner
Configuration menu - View commit details
-
Copy full SHA for 9bcd089 - Browse repository at this point
Copy the full SHA 9bcd089View commit details -
* theme_dirs generation done in helix_loader and not application.rs * getting theme directories is done through Editor for now. Goal is to unify all set_theme() preperation calls, somewhere. As it is currenply duplicated in typed.rs, application.rs, and editor.rs Toghether these points remove the need to pass down themeloader from `Application` to `Editor`.
Configuration menu - View commit details
-
Copy full SHA for 9de7893 - Browse repository at this point
Copy the full SHA 9de7893View commit details -
Just moved some lines around for a better understanding of what goes together with what.
Configuration menu - View commit details
-
Copy full SHA for 737b856 - Browse repository at this point
Copy the full SHA 737b856View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba7520b - Browse repository at this point
Copy the full SHA ba7520bView commit details -
Remove lang_configs_loader field from Appliction
Main purpose in application.rs was for it to then be passed down to Editor.
Configuration menu - View commit details
-
Copy full SHA for 692d744 - Browse repository at this point
Copy the full SHA 692d744View commit details -
All calls to the function were unwrapping it immediatedly after. Where `.expect("couldn't get terminal size")` was duplicated thrice in application.rs.
Configuration menu - View commit details
-
Copy full SHA for 4ba73b3 - Browse repository at this point
Copy the full SHA 4ba73b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf9fd51 - Browse repository at this point
Copy the full SHA cf9fd51View commit details -
config.load().editor.true_color || crate::true_color() or the like is was found a handful of times. Moves the logic of crate::true_color to Editor::default() constructor. This allows it to still be overriden by user configs whilst also removing the repeated OR expression.
Configuration menu - View commit details
-
Copy full SHA for ebe7ddf - Browse repository at this point
Copy the full SHA ebe7ddfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05d04f3 - Browse repository at this point
Copy the full SHA 05d04f3View commit details -
* True color support is now looked for once in main.rs, and checked internally in theme upon each theme update. * Removes theme::Loader all together * Theme errors notified on start-up just like all the other config parse errors.
Configuration menu - View commit details
-
Copy full SHA for 1055cd2 - Browse repository at this point
Copy the full SHA 1055cd2View commit details
Commits on Feb 16, 2023
-
* Leverage the existence of helix_loader::theme_dirs
Configuration menu - View commit details
-
Copy full SHA for dc1fa33 - Browse repository at this point
Copy the full SHA dc1fa33View commit details -
Place Impl blocks under stuct declarations
This commit merely moves around some blocks in theme.rs, making it slightly easier to read.
Configuration menu - View commit details
-
Copy full SHA for 6fde0e1 - Browse repository at this point
Copy the full SHA 6fde0e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6335989 - Browse repository at this point
Copy the full SHA 6335989View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95b227a - Browse repository at this point
Copy the full SHA 95b227aView commit details -
HELIX_LOG_LEVEL env variable can now also be set in a non integration test environment.
Configuration menu - View commit details
-
Copy full SHA for d1135f7 - Browse repository at this point
Copy the full SHA d1135f7View commit details -
Rename editor::Config to EditorConfig
Stupidly hard to differentiate it with config::Config.
Configuration menu - View commit details
-
Copy full SHA for 40a4e3d - Browse repository at this point
Copy the full SHA 40a4e3dView commit details -
A step in making it more in line to how the other configs are loaded.
Configuration menu - View commit details
-
Copy full SHA for 9a2257b - Browse repository at this point
Copy the full SHA 9a2257bView commit details -
make true color support bool a static
paves the way for a Default implementation for Theme
Configuration menu - View commit details
-
Copy full SHA for eceb19f - Browse repository at this point
Copy the full SHA eceb19fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a1038 - Browse repository at this point
Copy the full SHA 08a1038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73136a9 - Browse repository at this point
Copy the full SHA 73136a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 134e8bf - Browse repository at this point
Copy the full SHA 134e8bfView commit details -
Remove Option wrapper for Config.theme
Does so by assuming empty string implyies default theme in Theme::new. Paves the way to make Config::default() to be derivable.
Configuration menu - View commit details
-
Copy full SHA for 1678741 - Browse repository at this point
Copy the full SHA 1678741View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64eaf09 - Browse repository at this point
Copy the full SHA 64eaf09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28b60a9 - Browse repository at this point
Copy the full SHA 28b60a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4076e5 - Browse repository at this point
Copy the full SHA b4076e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d326827 - Browse repository at this point
Copy the full SHA d326827View commit details
Commits on Feb 17, 2023
-
custom description refinements
* Allow override of predifinde infobox descriptions. * Make sure that custom description overrider on infoboxes can be done without additional remappings of the same keytrie.
Configuration menu - View commit details
-
Copy full SHA for a0d918a - Browse repository at this point
Copy the full SHA a0d918aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ef96da - Browse repository at this point
Copy the full SHA 5ef96daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95a7d26 - Browse repository at this point
Copy the full SHA 95a7d26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31dc585 - Browse repository at this point
Copy the full SHA 31dc585View commit details