Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Darcula Solid theme #5778

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Add Darcula Solid theme #5778

merged 3 commits into from
Feb 7, 2023

Conversation

jesusmgg
Copy link
Contributor

@jesusmgg jesusmgg commented Feb 2, 2023

Based on the original Darcula, with darker and more contrasting colors.
image

Original repository: https://github.com/jesusmgg/darcula-solid-helix

@jesusmgg jesusmgg marked this pull request as ready for review February 2, 2023 06:53
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 2, 2023
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this overlap with Darcula much (changing the palette and a few scopes)? If so it would be good to re-use most of that theme with theme inheritance: https://docs.helix-editor.com/master/themes.html#inheritance

See the monokai_aqua theme for an example

@jesusmgg
Copy link
Contributor Author

jesusmgg commented Feb 2, 2023

Does this overlap with Darcula much (changing the palette and a few scopes)? If so it would be good to re-use most of that theme with theme inheritance: https://docs.helix-editor.com/master/themes.html#inheritance

See the monokai_aqua theme for an example

Makes sense, I'll look into it and update.

@jesusmgg
Copy link
Contributor Author

jesusmgg commented Feb 6, 2023

Now inheriting the original darcula theme as much as possible and applying changes over it.

@archseer archseer merged commit f71f27f into helix-editor:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants