Ignore invalid file URIs from LSP #6000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a call to
unwrap()
tomatch
. Currently the editor crashes when the LSP publishes diagnostics with an unsupported URI. With this PR it simply ignores them.Submitting this patch because the Cairo language server crashes Helix when it sends a file URI like
vfs://xxxxxx
wherevfs
refers to the internal in-memory file system of the Cairo language server.I'm not sure if this is considered a bug of the Cairo lang server as I don't know for sure if schemes other than
file
is allowed. But in any case I think we shouldn't panic here.