DAP: Add request ID to request timeout message #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-enhancement
pascalkuthe
previously approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Always good to have more detailed logging just like in #6010 👍 Especially with DAP integration hopefully seeing larger improvements and therefore more usage/testing in the future 👍
|
Thanks for you replying. I had rebase the commit with more message |
This improves error logging for dap requests. Without the ID it's hard to know which request is the one that timed out.
the-mikedavis
approved these changes
Feb 16, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
This improves error logging for dap requests. Without the ID it's hard to know which request is the one that timed out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves error logging for dap requests - without the ID it's hard to
know which request is the one that timed out, just like 6010.