Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themecheck to validate color codes in themes, ignore current known errors. #6019

Closed

Conversation

askreet
Copy link
Contributor

@askreet askreet commented Feb 16, 2023

Looking for some feedback on approach here while thinking about #5709.

This patch:

If this is interesting to folks the next steps would be:

  • Adding it to CI.
  • Plumbing the warnings from other bits of theme.rs up through Loader::load, too, and adding any known issues.

Notes:

  • I moved the "//TODO: alert the user..." comment up to a higher level in the code as I think that goal relates more to sending an event to the UI, which I haven't looked into.

@the-mikedavis
Copy link
Member

A check in the CI that fails when there are missing hexcodes would be a good addition but we don't want to add themelint to the CI. (Actually we might remove it in the long-run #5534 (comment).) If the palette check can be separated from the existing themelint xtask I think this would be a good change 👍

@askreet
Copy link
Contributor Author

askreet commented Feb 21, 2023

Great context, thanks @the-mikedavis. I'll separate these checks out.

@askreet
Copy link
Contributor Author

askreet commented Feb 22, 2023

Pushed up some changes to isolate a new check called themecheck that has been added to CI. Open to suggestions on the naming/scoping of the checks. @the-mikedavis

@askreet askreet changed the title Add known issues to themelint, include hex code parse errors. Add themecheck to validate color codes in themes, ignore current known errors. Feb 26, 2023
@kirawi kirawi added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 13, 2023
@askreet
Copy link
Contributor Author

askreet commented Mar 20, 2023

@archseer Can I get a quick 👍🏼 / 👎🏼 on whether this is interesting for the project? No pressure on merge timeline, but if you give me a 👍🏼 I will keep it up to date with master periodically, otherwise I'll close it out.

@askreet askreet closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants