Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add molokai theme #6260

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Add molokai theme #6260

merged 1 commit into from
Mar 13, 2023

Conversation

Zaechus
Copy link
Contributor

@Zaechus Zaechus commented Mar 10, 2023

Fixes #4704

Initial draft of a Molokai theme for Helix.

@archseer
Copy link
Member

The difference between monokai and molokai seems very minor: https://github.com/tomasr/molokai/blob/c67bdfcdb31415aa0ade7f8c003261700a885476/colors/molokai.vim#L112-L132

Perhaps you could inherit from the monokai theme and override just those colors?

@Zaechus
Copy link
Contributor Author

Zaechus commented Mar 12, 2023

Thanks for the suggestion! That made things a lot easier...

Here's an example of the Helix molokai theme vs Neovim:
image

I tried to get them as close as possible, but I was either unsure how to do some things or Helix's syntax highlighting had limitations compared to Neovim.

@Zaechus Zaechus marked this pull request as ready for review March 12, 2023 01:29
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please remember to add a screenshot to https://github.com/helix-editor/helix/wiki/Themes

@pickfire pickfire merged commit 951aecc into helix-editor:master Mar 13, 2023
@Zaechus Zaechus deleted the molokai branch March 13, 2023 17:58
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme request: Molokai
3 participants