Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog notes for the 23.03 release #6455

Merged
merged 11 commits into from
Mar 31, 2023
Merged

Add changelog notes for the 23.03 release #6455

merged 11 commits into from
Mar 31, 2023

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Mar 27, 2023

Release notes: helix-editor/website#33

@the-mikedavis the-mikedavis added this to the next milestone Mar 27, 2023
@the-mikedavis the-mikedavis added A-documentation Area: Documentation improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this togther! I know how much work this can be :D I noticed a few small things.

The usability improvements and bugfix section has been growing kind of large. Those are pretty hard to seperate but there is a lot of stuff in there now that I would categorize ass minor features that gets a bit lost between the bugfixes which not eberbody might read trough. For example the ability to have multiple runtime directories is a good example IMO. Not really that important and it's also good as is but might make the changes a bit more organized and break up that on really large list.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@the-mikedavis
Copy link
Member Author

Yeah I agree. I've been reserving the features part for really large stuff but I think it's actually ok to move all features under that header that aren't covered otherwise (commands for example). I think we can probably eliminate the LSP configurations section since that mostly overlaps with the new languages section

@pascalkuthe
Copy link
Member

Yeah I agree. I've been reserving the features part for really large stuff but I think it's actually ok to move all features under that header that aren't covered otherwise (commands for example). I think we can probably eliminate the LSP configurations section since that mostly overlaps with the new languages section

Yeah both of those changes sound like good suggestions 👍

Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah just saw you akready did this after I wrote my comment. Splitting up that section looks much nicer 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@archseer archseer self-requested a review March 28, 2023 04:35
This has a lot of overlap with the 'new languages' section with newly
supported LSP configurations. Smaller changes to LSP configurations
are not so common so I folded those into the 'updated languages and
queries' section.
@@ -1,3 +1,265 @@
# 23.03 (2023-03-31)
Copy link
Contributor

@pickfire pickfire Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-mikedavis I noticed every time you had to write this by looking at the logs, even though writing it from scratch will be better for the reader, but it is a lot of work, should we add an unreleased section so each new feature change needs to be written to that so you don't have to spend so much time on this? Or do you have an automated way to do it?

Copy link
Member

@pascalkuthe pascalkuthe Mar 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #4150 for previous discussion. I think the points raised there were pretty good. I could comeup with a solution which would somewhat automate it but I think Mikes point about that being an unnecessary effort still applies

23.03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add EOF for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but we would need to add some string trimming to the build file for helix_loader (and helix_term IIRC). For simplicity I just left the newline out

@archseer archseer marked this pull request as ready for review March 31, 2023 06:20
@archseer archseer merged commit ec55b4d into master Mar 31, 2023
@archseer archseer deleted the changelog branch March 31, 2023 06:21
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
* changelog: Checkpoint 2023-01-10

commit: 927fa11

* changelog: Checkpoint 2023-02-05

commit: 9c98043

* changelog: Checkpoint 2023-03-17

commit: bd47392

* changelog: Checkpoint 2023-03-27

commit: 5323020

* Set a tentative release date for 2023-03-31

* Update CHANGELOG.md

* Mention virtual text PR in inlayed type hints feature links

* Fix description for 5097

* Rebalance features, usability improvements and fixes

* Reorganize some out-of-place changes to the proper sections

* Eliminate the LSP configurations section

This has a lot of overlap with the 'new languages' section with newly
supported LSP configurations. Smaller changes to LSP configurations
are not so common so I folded those into the 'updated languages and
queries' section.
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
* changelog: Checkpoint 2023-01-10

commit: 927fa11

* changelog: Checkpoint 2023-02-05

commit: 9c98043

* changelog: Checkpoint 2023-03-17

commit: bd47392

* changelog: Checkpoint 2023-03-27

commit: 5323020

* Set a tentative release date for 2023-03-31

* Update CHANGELOG.md

* Mention virtual text PR in inlayed type hints feature links

* Fix description for 5097

* Rebalance features, usability improvements and fixes

* Reorganize some out-of-place changes to the proper sections

* Eliminate the LSP configurations section

This has a lot of overlap with the 'new languages' section with newly
supported LSP configurations. Smaller changes to LSP configurations
are not so common so I folded those into the 'updated languages and
queries' section.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* changelog: Checkpoint 2023-01-10

commit: 927fa11

* changelog: Checkpoint 2023-02-05

commit: 9c98043

* changelog: Checkpoint 2023-03-17

commit: bd47392

* changelog: Checkpoint 2023-03-27

commit: 5323020

* Set a tentative release date for 2023-03-31

* Update CHANGELOG.md

* Mention virtual text PR in inlayed type hints feature links

* Fix description for 5097

* Rebalance features, usability improvements and fixes

* Reorganize some out-of-place changes to the proper sections

* Eliminate the LSP configurations section

This has a lot of overlap with the 'new languages' section with newly
supported LSP configurations. Smaller changes to LSP configurations
are not so common so I folded those into the 'updated languages and
queries' section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: Documentation improvements S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants