Move UI components to helix-view and keep rendering logic in helix-term #711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps the rendering logic of components ("widgets") like
FilePicker
,EditorView
, etc inhelix-term
and moves the structs themselves tohelix-view
. This is being done with the end goal of separatingCompositor
out to a trait (see #39 (comment) for why this is necessary) which will unblock the path to a GUI implementation.The specific design I'm thinking of following is described in #618 (comment). Even if the proposed design (for the end goal for a
Compositor
trait) is not the best one, I think there is value in separating the rendering logic from everything else. Different frontends will want to do rendering their own way, but we still need to provide a base set of components that the editor will use and the frontends can implement. This PR attempts to move those base components intohelix-view
and leaves the rendering logic open to implementation (one such implementation will behelix-term
, and others will be GUIs in the future).Note: A single commit will move only a single component so as to make reviewing easier.