-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blueprint language #7213
Add blueprint language #7213
Conversation
ivktac
commented
Jun 3, 2023
•
edited
Loading
edited
- Add blueprint tree-sitter queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit, otherwise this looks good.
It looks like blueprint includes an official language server that could be added too if it works out of the box: https://jwestman.pages.gitlab.gnome.org/blueprint-compiler/#features
(Connects #7121)
languages.toml
Outdated
|
||
[[grammar]] | ||
name = "blueprint" | ||
source = { git = "https://gitlab.com/gabmus/tree-sitter-blueprint.git", rev = "7f1a5df44861291d6951b6b2146a9fef4c226e14" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source = { git = "https://gitlab.com/gabmus/tree-sitter-blueprint.git", rev = "7f1a5df44861291d6951b6b2146a9fef4c226e14" } | |
source = { git = "https://gitlab.com/gabmus/tree-sitter-blueprint", rev = "7f1a5df44861291d6951b6b2146a9fef4c226e14" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
I'd like to note that the LSP does not seem to be working correctly. I don't know if the problem is in my configuration (I just copy-pasted from https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#blueprint_ls) or with blueprint-compiler. helix.log
|
Ah ok, we can leave it out of this PR and leave it for future work. That looks like an upstream issue where the language server is sending something for the semantic tokens provider capabilities that doesn't match the LSP spec. |
Should I revert the commit or just leave it as it is? |
Actually it's probably ok to leave it in this PR. Once that gets resolved upstream, the language server should work fine without any more changes to Helix. There isn't really any downside of a language server breaks spec like this: it just won't be initialized so the LSP features won't work. |
don't have gnome gitlab account so posting here the reason why |
Thanks, @gabydd.The problem was indeed that |
* Add blueprint tree-sitter support * Add blueprint lsp support * Run cargo xtask docgen
* Add blueprint tree-sitter support * Add blueprint lsp support * Run cargo xtask docgen
* Add blueprint tree-sitter support * Add blueprint lsp support * Run cargo xtask docgen
* Add blueprint tree-sitter support * Add blueprint lsp support * Run cargo xtask docgen