Jinja language family syntax support #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
previously approved these changes
Jun 13, 2023
the-mikedavis
previously approved these changes
Jun 19, 2023
There was a problem hiding this comment.
In the long run I think we'll want a way to detect the language that is being templated. Jinja2 is usually used for HTML but you can use it for any kind of template so usually I see filename.<ext>.j2 where <ext> is html, js, etc. depending on the language being templated. Ideally we would inject that language but that can be left for future work.
the-mikedavis
added
S-waiting-on-author
the-mikedavis
approved these changes
Aug 9, 2023
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Aug 9, 2023
|
Thank you so much for this. Now the only language I'm missing is pugjs :) |
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
* feat: add jinja language support * feat: add nunjucks language support * feat: add to lang support book jinja and nunjucks languages
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* feat: add jinja language support * feat: add nunjucks language support * feat: add to lang support book jinja and nunjucks languages
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* feat: add jinja language support * feat: add nunjucks language support * feat: add to lang support book jinja and nunjucks languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add jinja grammar for nunjuncks and jinja languages.
