Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fsharp language support #7619

Merged
merged 3 commits into from
Jul 15, 2023
Merged

Add fsharp language support #7619

merged 3 commits into from
Jul 15, 2023

Conversation

kaashyapan
Copy link
Contributor

@the-mikedavis the-mikedavis linked an issue Jul 13, 2023 that may be closed by this pull request
F# for Helix? #4943
Closed
the-mikedavis
the-mikedavis requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs highlight queries, see #6002 for example.

Btw you can try these changes locally by running cargo run or building this branch from source.

languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Jul 13, 2023
@the-mikedavis the-mikedavis changed the title Added fsharp language support Add fsharp language support Jul 13, 2023
@kaashyapan kaashyapan force-pushed the fsharp-language-support branch from 6b972ab to 6d0bde2 Compare July 14, 2023 05:15
@kaashyapan kaashyapan force-pushed the fsharp-language-support branch from 6d0bde2 to 1a48090 Compare July 14, 2023 05:46
@kaashyapan
Copy link
Contributor Author

Screenshot 2023-07-14 at 11 14 10 AM

@kaashyapan kaashyapan requested a review from the-mikedavis July 14, 2023 16:54
@pascalkuthe pascalkuthe merged commit 2ace603 into helix-editor:master Jul 15, 2023
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@kaashyapan @mtoohey31
Add fsharp language support (helix-editor#7619)
df850d8
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@kaashyapan
Add fsharp language support (helix-editor#7619)
f2f3bfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F# for Helix?
3 participants
@kaashyapan @the-mikedavis @pascalkuthe