Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text objects for protobuf #7869

Closed
wants to merge 2 commits into from
Closed

Add text objects for protobuf #7869

wants to merge 2 commits into from

Conversation

john-h-k
Copy link
Contributor

@john-h-k john-h-k commented Aug 8, 2023

  • service and message are type objects
  • rpcs are functions, both around and inside selects entire line (as they have no body)
  • identifiers within rpcs are parameters, although pretty useless as there can only be one

the-mikedavis
the-mikedavis reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run cargo xtask docgen and commit the results that will fix the docs CI

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Sep 4, 2023
@pascalkuthe
Copy link
Member

Seems #9184 was already merged. Can this be closed then?

@the-mikedavis
Copy link
Member

Yep it looks to me like this and #9184 have almost the same patterns, just written out differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-h-k @pascalkuthe @the-mikedavis