Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Maskhjarnas tree-sitter-purescript #8306

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Use Maskhjarnas tree-sitter-purescript #8306

merged 4 commits into from
Sep 17, 2023

Conversation

NomisIV
Copy link
Contributor

@NomisIV NomisIV commented Sep 16, 2023

Currently PureScript piggybacks on the haskell tree-sitter, which is less than optimal. I use @Maskhjarna's tree-sitter-purescript, which currently is the most feature complete implementation. I use this daily in my work, and while it has a couple bugs, it's far better than the haskell tree-sitter.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the docs CI you'll also need to run cargo xtask docgen and commit the results

runtime/queries/purescript/textobjects.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Sep 16, 2023
@NomisIV
Copy link
Contributor Author

NomisIV commented Sep 17, 2023

Thank you for the review! I have now fixed the issues, and CI should pass. :)

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 17, 2023
@pascalkuthe pascalkuthe merged commit cb39242 into helix-editor:master Sep 17, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants