Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add graphql-lsp support #8492

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

kjuulh
Copy link
Contributor

@kjuulh kjuulh commented Oct 8, 2023

graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service, but the binary shipped is called graphql-lsp hence the strange naming scheme

@kjuulh kjuulh force-pushed the feat/with-graphql-lsp branch from 969ca66 to 4352b52 Compare October 8, 2023 20:40
languages.toml Outdated Show resolved Hide resolved
@kjuulh kjuulh force-pushed the feat/with-graphql-lsp branch from 4352b52 to c96ee72 Compare October 8, 2023 20:59
@kjuulh kjuulh requested a review from the-mikedavis October 8, 2023 21:00
the-mikedavis
the-mikedavis previously approved these changes Oct 8, 2023
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Oct 8, 2023
pascalkuthe
pascalkuthe previously approved these changes Oct 8, 2023
@pascalkuthe
Copy link
Member

please run cargo xtask docgen and commit the changes to ensure CI passes and we can merge

@kjuulh
Copy link
Contributor Author

kjuulh commented Oct 8, 2023

Yep. Saw that it broke after i fixed a typo. Will do so first thing tomorrow

graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service,
but the binary shipped is called graphql-lsp hence the strange naming scheme

Signed-off-by: kjuulh <contact@kjuulh.io>
@kjuulh kjuulh dismissed stale reviews from pascalkuthe and the-mikedavis via c8344d7 October 9, 2023 06:38
@kjuulh kjuulh force-pushed the feat/with-graphql-lsp branch from c96ee72 to c8344d7 Compare October 9, 2023 06:38
@pascalkuthe pascalkuthe merged commit 5cb76e7 into helix-editor:master Oct 9, 2023
danillos pushed a commit to danillos/helix that referenced this pull request Nov 21, 2023
graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service,
but the binary shipped is called graphql-lsp hence the strange naming scheme

Signed-off-by: kjuulh <contact@kjuulh.io>
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service,
but the binary shipped is called graphql-lsp hence the strange naming scheme

Signed-off-by: kjuulh <contact@kjuulh.io>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service,
but the binary shipped is called graphql-lsp hence the strange naming scheme

Signed-off-by: kjuulh <contact@kjuulh.io>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
graphql-lsp has quite the strange name upstream, the project is technically called graphql-language-service,
but the binary shipped is called graphql-lsp hence the strange naming scheme

Signed-off-by: kjuulh <contact@kjuulh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants