-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some grammars to a commit where the license file is included #9279
Conversation
runtime/queries/pod/highlights.scm
Outdated
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head1") | ||
(content) @markup.heading.1) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head2") | ||
(content) @markup.heading.2) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head3") | ||
(content) @markup.heading.3) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head4") | ||
(content) @markup.heading.4) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head5") | ||
(content) @markup.heading.5) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head6") | ||
(content) @markup.heading.6) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This heading styling seems to have been reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet resolved: the pattern on L7 should match =head1
, =head2
, etc. and use the markup.heading.1
, markup.heading.2
, etc. captures
runtime/queries/pod/highlights.scm
Outdated
(interior_sequence | ||
(sequence_letter) @character | ||
(#eq? @character "B") | ||
(content) @text.strong) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these @text
styles are wrong and should use the @markup
styles we had before
runtime/queries/pod/highlights.scm
Outdated
(#not-match? @keyword "^=(head|over|item|encoding)") | ||
(content) @string) | ||
|
||
(verbatim_paragraph (content) @text.literal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was @markup.raw
Co-authored-by: Blaž Hrastnik <blaz@mxxn.io>
Thanks for the review! I applied your suggested changes. |
runtime/queries/pod/highlights.scm
Outdated
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head1") | ||
(content) @markup.heading.1) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head2") | ||
(content) @markup.heading.2) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head3") | ||
(content) @markup.heading.3) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head4") | ||
(content) @markup.heading.4) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head5") | ||
(content) @markup.heading.5) | ||
(head_paragraph | ||
(head_directive) @directive | ||
(#eq? @directive "=head6") | ||
(content) @markup.heading.6) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet resolved: the pattern on L7 should match =head1
, =head2
, etc. and use the markup.heading.1
, markup.heading.2
, etc. captures
runtime/queries/pod/highlights.scm
Outdated
(content) @markup.link.url) | ||
(sequence_letter) @character | ||
(#eq? @character "E") | ||
(content) @string.escape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(content) @string.escape) | |
(content) @string.special.escape) |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
…elix-editor#9279) Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
This is the second part of #8691.
This PR should include all remaining grammars, that don't have license files. Except
tree-sitter-eex
because upstream seems to be dead.I am unsure if the changes to the
scm
files are 100% OK. I'd appreciate it if someone could double check them.