Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (#8809)" #9548

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (#8809)" #9548

merged 1 commit into from
Feb 7, 2024

Conversation

pashadia
Copy link
Contributor

@pashadia pashadia commented Feb 6, 2024 •
edited by the-mikedavis
Loading

The dependency cc version 1.0.84 was yanked. Here is the explanation on the release page.

This PR simply reverts back to the previous version of the dependency. Fixes #8820.

the-mikedavis
the-mikedavis approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that CC would cut a 1.0.85 release reverting the change and dependabot would clean this up but it's been a while since 1.0.84 was released, so let's downgrade 👍

@the-mikedavis the-mikedavis added A-dependencies Area: Dependency rust Pull requests that update Rust code S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 6, 2024
Agilan989
Agilan989 reviewed Feb 6, 2024
View reviewed changes
Copy link

@Agilan989 Agilan989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to asking about for transportation to when from platform they are connecting with account how??? Because notifications never get to if not I stopped using my account

@pashadia
Copy link
Contributor Author

pashadia commented Feb 6, 2024

Need to asking about for transportation to when from platform they are connecting with account how??? Because notifications never get to if not I stopped using my account

I'm sorry, I don't understand your reply. @Agilan989 is this where you intended to write it?

@archseer archseer merged commit c64a0e6 into helix-editor:master Feb 7, 2024
6 checks passed
cosmikwolf pushed a commit to cosmikwolf/helix that referenced this pull request Feb 26, 2024
@pashadia @cosmikwolf
Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (helix-editor#8809)…
6b0b865 
…" (helix-editor#9548)
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@pashadia @postsolar
Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (helix-editor#8809)…
a140231 
…" (helix-editor#9548)
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@pashadia @mtoohey31
Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (helix-editor#8809)…
042904c 
…" (helix-editor#9548)
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@pashadia @Vulpesx
Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (helix-editor#8809)…
a826ceb 
…" (helix-editor#9548)
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@pashadia
Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (helix-editor#8809)…
b444f40 
…" (helix-editor#9548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Agilan989 Agilan989 Agilan989 left review comments

@archseer archseer archseer approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-dependencies Area: Dependency rust Pull requests that update Rust code S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation in a macOS GitHub runner fails with cc v1.0.84
4 participants
@pashadia @archseer @the-mikedavis @Agilan989