Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse Nix highlights queries #9849

Conversation

postsolar
Copy link
Contributor

@postsolar postsolar commented Mar 11, 2024

Related issue: #9436

I looked into injections too, and most of them don't work for me (eg builders). But they don't work for me on master either, so I'm not sure what's the issue, and at least reversing doesn't seem to introduce any new breakage. nevermind they seem to all work.

@the-mikedavis the-mikedavis self-requested a review March 12, 2024 13:01
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few more patterns to move but otherwise this looks like it's working 👍

runtime/queries/nix/highlights.scm Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Mar 16, 2024
@postsolar postsolar force-pushed the update-nix-queries branch from 327c1f4 to 6a90105 Compare March 17, 2024 19:43
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis merged commit 917ada3 into helix-editor:reverse-query-precedence-ordering Mar 17, 2024
6 checks passed
@postsolar postsolar deleted the update-nix-queries branch April 4, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants