Initial Ada language support (after stale) #9908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PR from tomekw
…r switch to ada LSP
the-mikedavis
added
S-waiting-on-author
|
Overall question - are there any language support related tests needed? Do helix have them? |
|
There isn't currently a way to do unit tests for language support (highlighting, textobjects, etc.) |
the-mikedavis
approved these changes
Mar 19, 2024
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Mar 19, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Mar 26, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
|
Wow! Thank you! My life got in a way and I couldn't dedicate time to make it working. Can't wait to test it! |
Sounds great that you're back man. If you need, do not hesitate to contact me privately. |
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Adding initial support for ada language, based off helix-editor#7790 PR from tomekw * More translation to helix-specific tree-sitter scm labels, add ada gpr switch to ada LSP * Generate ada in lang-support.md using cargo xtask docgen * Update tree-sitter definitions according to comments * Remove .gpr glob from languages.toml * Fix unit in languages.toml for ada, update locals.scm to helix needs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
My first PR here :)
I've seen PR #7791 but it's stalled, so I've picked that work here. Sorry about wrong hash in the commit!
This PR adds ada language support on tree-sitter side, as well as language.toml side. I've tried applying suggestions from tomekw PR to my fork.