Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog notes for 24.03 #9946
Add changelog notes for 24.03 #9946
Changes from 2 commits
7f006c9
d1ca69e
b6dd74e
1c980ae
60ee6a6
c16cb85
98c6c1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 24.03.0 rather than 24.3.0?
relates to Homebrew/homebrew-core#167564
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally yes but Cargo doesn't consider it a valid version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any cargo issue for this?
Somehow this version scheme worked before? see Homebrew/homebrew-core#131283
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - it's a conflict of us using the version as CalVer but cargo explicitly only supporting SemVer so I doubt cargo would be interested in changing it.
The way we handle the version changed in the 23.10 release with #8925 but this effect wasn't visible yet because of the October release (
10
). Previously we had all crate versions at v0.6.0 (the last SemVer release version) and used an ad-hocVERSION
file and constant for the CalVer version.