Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stop including cockpit's deprecated bundled jquery #2

Closed
martinpitt opened this issue Feb 5, 2018 · 2 comments
Closed

Please stop including cockpit's deprecated bundled jquery #2

martinpitt opened this issue Feb 5, 2018 · 2 comments

Comments

@martinpitt
Copy link

This project currently uses jquery from cockpit:

 <script type="text/javascript" src="../base1/jquery.js"></script>

Please stop doing that and include your own from npmjs.org instead. If you rely on a particular jQuery version, this might break underneath you. Please see https://lists.fedorahosted.org/archives/list/cockpit-devel@lists.fedorahosted.org/thread/TDBKI4372I4ZPGQFCZB377DX2QG2YDDY/ for more information.

Particularly, cockpit will update to jQuery 3.0 soon (cockpit-project/cockpit#8505) which has quite a lot of changes, see the upgrade guide.

@martinpitt martinpitt changed the title Please stop including cockpit's bundled jquery Please stop including cockpit's deprecated bundled jquery Feb 5, 2018
@martinpitt
Copy link
Author

To clarify: This was not really your fault, but entirely our's -- sorry if the wording indicated otherwise. Cockpit's own examples and documentation included this (which got fixed now), but it's a potential breakage for any external cockpit extensions, so this needs to be cleaned up.

Thanks!

hellcatz added a commit that referenced this issue Feb 18, 2018
Added support for `z_shieldcoinbase`
Added support for `sendtoaddress`
Support jQuery 3.0 in response to #2
hellcatz added a commit that referenced this issue Feb 18, 2018
Added support for `z_shieldcoinbase`
Added support for `sendtoaddress`
Support jQuery 3.0 in response to #2
hellcatz added a commit that referenced this issue Feb 18, 2018
@hellcatz
Copy link
Owner

Thank you for reaching out to my little project.
I have updated code in this commit c4c29b1 in pending PR from multi-coin branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants