test: migrate from enzyme to @testing-library/react #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100terres
force-pushed
the
318-migrate-from-enzyme-to-testing-library-react
branch
2 times, most recently
from
454cbc1 to
21f54c8
Compare
100terres
commented
Apr 13, 2022
100terres
commented
Apr 13, 2022
5 tasks
100terres
force-pushed
the
318-migrate-from-enzyme-to-testing-library-react
branch
3 times, most recently
from
0cf0840 to
5dd5999
Compare
100terres
force-pushed
the
318-migrate-from-enzyme-to-testing-library-react
branch
from
5dd5999 to
26b69ab
Compare
Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed.
100terres
force-pushed
the
318-migrate-from-enzyme-to-testing-library-react
branch
from
26b69ab to
d2005ff
Compare
100terres
commented
Apr 14, 2022
Comment on lines
+12
to
+25
| // Spy Placeholder component | ||
| jest.mock('../../../../src/view/placeholder', () => jest.fn()); | ||
| // eslint-disable-next-line import/newline-after-import, import/first | ||
| import _Placeholder from '../../../../src/view/placeholder'; | ||
| const Placeholder = jest.mocked(_Placeholder); | ||
| const { default: OriginalPlaceholder } = jest.requireActual<{ | ||
| default: typeof _Placeholder; | ||
| }>('../../../../src/view/placeholder'); | ||
|
|
||
| beforeEach(() => { | ||
| Placeholder.mockImplementation((props: any) => { | ||
| return <OriginalPlaceholder {...props} />; | ||
| }); | ||
| }); |
100terres
added a commit
that referenced
this pull request
Aug 21, 2022
* test(dev-deps): remove enzyme libraries from package.json * test(setup): remove enzyme related configuration * test: move REACT_VERSION global declaration * test(dev-deps): setup @testing-library/jest-dom for more details see: https://github.com/testing-library/jest-dom#usage= * test(jsdom env): fix issue with missing TransitionEvent * test(enzyme): drop Placeholder without memo (needed for enzyme) * test(enzyme): drop force upfate util * test(enzyme): drop PassThroughProps util component Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed. * test(util): drop un-used user input util * test(enzyme): migrate all tests using enzyme to @testing-library/react * chore: bump size snapshot
100terres
added a commit
that referenced
this pull request
Aug 21, 2022
* test(dev-deps): remove enzyme libraries from package.json * test(setup): remove enzyme related configuration * test: move REACT_VERSION global declaration * test(dev-deps): setup @testing-library/jest-dom for more details see: https://github.com/testing-library/jest-dom#usage= * test(jsdom env): fix issue with missing TransitionEvent * test(enzyme): drop Placeholder without memo (needed for enzyme) * test(enzyme): drop force upfate util * test(enzyme): drop PassThroughProps util component Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed. * test(util): drop un-used user input util * test(enzyme): migrate all tests using enzyme to @testing-library/react * chore: bump size snapshot
100terres
added a commit
that referenced
this pull request
Aug 21, 2022
* test(dev-deps): remove enzyme libraries from package.json * test(setup): remove enzyme related configuration * test: move REACT_VERSION global declaration * test(dev-deps): setup @testing-library/jest-dom for more details see: https://github.com/testing-library/jest-dom#usage= * test(jsdom env): fix issue with missing TransitionEvent * test(enzyme): drop Placeholder without memo (needed for enzyme) * test(enzyme): drop force upfate util * test(enzyme): drop PassThroughProps util component Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed. * test(util): drop un-used user input util * test(enzyme): migrate all tests using enzyme to @testing-library/react * chore: bump size snapshot
100terres
added a commit
that referenced
this pull request
Aug 21, 2022
* test(dev-deps): remove enzyme libraries from package.json * test(setup): remove enzyme related configuration * test: move REACT_VERSION global declaration * test(dev-deps): setup @testing-library/jest-dom for more details see: https://github.com/testing-library/jest-dom#usage= * test(jsdom env): fix issue with missing TransitionEvent * test(enzyme): drop Placeholder without memo (needed for enzyme) * test(enzyme): drop force upfate util * test(enzyme): drop PassThroughProps util component Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We must use the `rerender` function and we can directly change the prop of child component in the tree if needed. * test(util): drop un-used user input util * test(enzyme): migrate all tests using enzyme to @testing-library/react * chore: bump size snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #318