[fix](block) add block columns size dcheck (apache#28539)

hello-stephen · Dec 28, 2023 · a3e8bb5 · a3e8bb5
1 parent c8bac6c
commit a3e8bb5
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/be/src/vec/core/block.cpp b/be/src/vec/core/block.cpp
@@ -584,15 +584,19 @@ MutableColumns Block::mutate_columns() {
 }
 
 void Block::set_columns(MutableColumns&& columns) {
- /// TODO: assert if |columns| doesn't match |data|!
+ DCHECK_GE(columns.size(), data.size())
+ << fmt::format("Invalid size of columns, columns size: {}, data size: {}",
+ columns.size(), data.size());
  size_t num_columns = data.size();
  for (size_t i = 0; i < num_columns; ++i) {
  data[i].column = std::move(columns[i]);
  }
 }
 
 void Block::set_columns(const Columns& columns) {
- /// TODO: assert if |columns| doesn't match |data|!
+ DCHECK_GE(columns.size(), data.size())
+ << fmt::format("Invalid size of columns, columns size: {}, data size: {}",
+ columns.size(), data.size());
  size_t num_columns = data.size();
  for (size_t i = 0; i < num_columns; ++i) {
  data[i].column = columns[i];