Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages and rules #5

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update packages and rules #5

wants to merge 11 commits into from

Conversation

JaceHensley
Copy link
Contributor

Ultimate Problem

These packages had really outdated deps and the eslint rules were written ourselves which can be daunting to keep updated

Solution

  • Update deps
  • Remove the separate @bloomprotocol/eslint-config-react package, replaced with a react config in the @bloomprotocol/eslint-config package
  • Use airbnb's eslint config as a starting point
  • Turn off specific rules that we don't want to follow, and tweak others to fit better for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaceHensley @djvs