[FINCC-3466] Add Billing Address to Payment Method Create Request #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sc
approved these changes
Apr 22, 2020
|
|
Seklfreak
approved these changes
Apr 22, 2020
|
👍
|
|
|
saopayne
force-pushed
the
feature/FINCC-3466-add-payment_method-billing-address
branch
from
005cd52 to
f210a07
Compare
Seklfreak
approved these changes
Apr 22, 2020
|
👍
|
|
|
|
+1
|
saopayne
deleted the
feature/FINCC-3466-add-payment_method-billing-address
branch
puellanivis
reviewed
Apr 22, 2020
| // Update using different credit card | ||
| rand.Seed(time.Now().UTC().UnixNano()) | ||
| token := fmt.Sprintf("btgo_test_token_%d", rand.Int()+1) | ||
| t.Fatal(token) |
There was a problem hiding this comment.
Was added during testing locally for this file. Will remove shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://hellofresh.atlassian.net/browse/FINCC-3466
Description:
For PaymentMethod::Create and PaymentMethod::Update request, we need to include the
BillingAddressin the payload to be sent to the PSP.This is required to increase the acceptance rate of the payment method specifically in countries like US.
Testing
Ran the integration tests locally for Payment method and billing address was sent along.