-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customdata to Jmeter tests (#179) #180
Conversation
f8a42b5
to
aa5b859
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
- Coverage 59.74% 58.22% -1.53%
==========================================
Files 36 36
Lines 2760 2834 +74
==========================================
+ Hits 1649 1650 +1
- Misses 991 1062 +71
- Partials 120 122 +2
Continue to review full report at Codecov.
|
@lucasmdrs friendly ping 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amandahla thanks for the contribution! 💚
I'm leaving a couple of comments, please take a look when you have the time
Also, please make sure to document those environment variables 📝
@lucasmdrs It seems like the same problem that happened in #206 , right? |
hey @amandahla , that's a different one. there are some trailing spaces in the doc:
|
Thank you for the awesome contribution @amandahla ! |
Implementation of #179
Requirement: The Dynamic volume provisioning must be set on the cluster
If JMETER_WORKER_REMOTE_CUSTOM_DATA_ENABLED is set, before pod creation, a PVC will be created asking the cluster for a volume of size defined in the environment variable JMETER_WORKER_REMOTE_CUSTOM_DATA_VOLUME_SIZE and access mode ReadWriteMany.
The volume will be the same for all pods and data from S3 bucket will be cloned using Rclone
Get variables from envvar file: