Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify get_traffic_from_iptables() to be compatible with CentOS 6 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gunziyang
Copy link

No description provided.

@hellofwy
Copy link
Owner

hellofwy commented Jul 8, 2017

Thanks for the Pull request.
Actually I don't know the details about the differences between Linux distributions. So I can't review the changes.
Can you or someone provide some test results of the changes on popular Linux distributions?

@gunziyang
Copy link
Author

gunziyang commented Jul 8, 2017

你想要什么样的测试结果?抱歉,git commit的时候那台机器不支持中文,所以用英文提交了[捂脸].

@hellofwy
Copy link
Owner

hellofwy commented Jul 8, 2017

其实,我水平有限,所以写了这个脚本后,就没怎么更新过了。
所以我内心不怎么想合并新修改了,感觉能力和精力都不够。
好在很多人 fork 之后,根据自己的需求添加了不少功能。
所以感谢你的修改,这个 request 我就不关了,希望有对应需要的能看到。
希望你能理解,而且以后也能积极为其他开源项目贡献代码。

@gunziyang
Copy link
Author

gunziyang commented Jul 15, 2017 via email

@huangzhic
Copy link

感谢你,修改之后再CentOS 6下可以统计流量了

@Fndroid
Copy link

Fndroid commented Oct 14, 2017

棒哦CentOS7也可用

@gunziyang
Copy link
Author

gunziyang commented Oct 18, 2017

@hellofwy 突然想起一个事,我修改的时候,没有考虑兼容Debian。

也就是说,正确的做法应该是

if(centos) 用我修订过的规则
if(Debian) 用原来的规则

或者

用一套能兼容两个系统的规则

而我的做法是

用我修订过的规则

我的做法有可能导致我修订过的版本在Debian下不能正常使用。

求有心人测试。

@2882889
Copy link

2882889 commented Mar 8, 2018

@gunziyang iptables: No chain/target/match by that name 修改适配centos6以后 命令行老出现这个提示是怎么回事呀,希望你有时间帮我解答一下,谢谢啦,还有一个问题是我的流量总是和服务器控制面板的不一样,没有控制面板使用的多,是不是我哪里设置有问题呀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants