Merge develop to master #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter returns a lazy iterable object in python 3. Can use list() to convert the result to a list but i think using list comprehension here is more idiomatic.
Python 3 has urllib.request and python 2 has urllib. Hence using six.moves.urllib to make the code compatible with both 2 and 3. Also six.text_type evaluates to unicode() for python 2 and str for python 3.
2nd set of python 2 and 3 compatible changes
|
👍 No lint errors found. |
|
retest this please |
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 68.16% 68.29% +0.13%
==========================================
Files 65 65
Lines 4859 4880 +21
==========================================
+ Hits 3312 3333 +21
Misses 1547 1547
Continue to review full report at Codecov.
|
chiragjn
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Py2-3 import compatibility changes