Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to Master #367

Merged
merged 11 commits into from
May 29, 2020
Merged

Develop to Master #367

merged 11 commits into from
May 29, 2020

Conversation

chiragjn
Copy link
Contributor

  • Fix MemoryError for RegexDetector
  • cleanup dead code related to gunicorn

chiragjn added 11 commits May 7, 2020 16:53
@chiragjn
Cleanup - Remove gunicorn and start_server.sh
9d7f811
@chiragjn
Set DEBUG=False, no more configurable from .env
b22d75b
@chiragjn
Merge pull request #362 from hellohaptik/dj_debug_false
a5457ce 
Set DEBUG=False, no more configurable from .env
@chiragjn
Minor update to install.md
c865f5a
@chiragjn
Merge pull request #363 from hellohaptik/setup-doc-update-052020
0967500 
Minor update to install.md
@chiragjn
fix(regex-detector): Fix MemoryError caused by recrusive replace and
7b7365e 
                     limit max_matches to 50 by default

When replacing something like 'ab' -> 'abab' or '' with anything in a loop can grow string
causing more and more allocations, eventually crashing with MemoryError.
We fix this by doing careful replacements with a special placeholder and
also discarding empty matches and limiting matches to keep the detector
fast. The max_matches part is configurable via __init__
https://hello-haptik.atlassian.net/browse/ML-1443
@chiragjn
Fix TypeError, append strs not lists
39348a1
@chiragjn
Add a dot star test case, refactor tests and use safeloader for yaml …
8312e3e 
…files
@chiragjn
Fix lint error for unused vars
8bc67a2
@chiragjn
Merge pull request #365 from hellohaptik/fix_re_mem_err
78601ab 
fix(regex-detector): Fix MemoryError caused by recursive replace and limit max_matches to 50 by default
@chiragjn
Merge pull request #360 from hellohaptik/cleanup_gunicorn
92412cd 
Cleanup - Remove gunicorn and start_server.sh
@srajdev
Copy link
Contributor

srajdev commented May 27, 2020

👍 No lint errors found.

@chiragjn chiragjn merged commit e7c3146 into master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krupalmodi18 krupalmodi18 krupalmodi18 approved these changes

Assignees
No one assigned
Labels
bug-fixes code-cleanup miscellaneous No lint errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chiragjn @srajdev @krupalmodi18