Develop to Master #375
Merged
Develop to Master #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [django](https://github.com/django/django) from 1.11.28 to 1.11.29. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@1.11.28...1.11.29) Signed-off-by: dependabot[bot] <support@github.com>
Bump django from 1.11.28 to 1.11.29
Some mappings were found to be manually put outside of code with creates a problem with new setups.
Date Test Changes
…into es_update_mappings
Update Elasticsearch mappings for entity indices
Create pull_request_template.md
|
UNIT TESTS HAVE PASSED... Good To Merge |
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 68.35% 71.19% +2.83%
==========================================
Files 65 76 +11
Lines 4876 5749 +873
==========================================
+ Hits 3333 4093 +760
- Misses 1543 1656 +113
Continue to review full report at Codecov.
|
* To add support for elastic search datastore * To add support for multi entity text detection * To add new endpoint for multi_entity_text detection How: * By creating package for es_datastore * By adding function for generating and parsing es query and results * By adding entry in urls and creating a placeholder view
Add support standalone es datastore for multi entity text detection
|
UNIT TESTS HAVE PASSED... Good To Merge |
Why: * To add new detector module for text detection * To add support for new api endpoint in v2 for text detection * To add support for new api endpoint in v2 for bulk text detection How: * By adding a new module for text_detection in detectors/textual * By adding moudle for utility function to parse and get text deetction * By adding appropriate urls and api view for new api endpoint i.e. v2/text, v2/text_bulk
only single msearch query for structured and normat text entities - Add validation on number of messages and texts for bulk detection
…tion_data` - Change appropriate unit tests
…t of `[[]]` - Change parameter name `messsage` to `messages` in request body
- To set default fuzziness value for parsing es result to `auto:4,7` - To change substituion cost to `1` for v2/text
…` and `set_fuzziness_low_high_threshold` method
Add support for text detetction for multi entity multi text in ner_v2
|
UNIT TESTS HAVE PASSED... Good To Merge |
ankur09011
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes -> mostly C/I fixes and datastore create related changes
Major changes -> New v2/text API for detecting multiple text entities on multiple texts at once!