Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langauge support for person name #385

Merged
merged 44 commits into from
Dec 8, 2020
Merged

Langauge support for person name #385

merged 44 commits into from
Dec 8, 2020

Conversation

ashutoshsingh0223
Copy link
Contributor

@ashutoshsingh0223 ashutoshsingh0223 commented Dec 8, 2020

JIRA Ticket Number

JIRA TICKET: https://hello-haptik.atlassian.net/browse/ML-2048

Description of change

  • More languages supported for person name detection through POS Tagging
  • Completely remove regex patterns from NameDetection class
  • Enforce previous message check for name detection.

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ashutoshsingh0223 and others added 30 commits November 4, 2020 14:29
….TestESDataStore.test_add_query to use env variables
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
ner_v1/detectors/textual/name/hindi_const.py Show resolved Hide resolved
lib/nlp/spacy_utils.py Show resolved Hide resolved
lib/nlp/tests/test_nlp_utils.py Show resolved Hide resolved
@ashutoshsingh0223 ashutoshsingh0223 added new-feature Added new functionality miscellaneous labels Dec 8, 2020
Copy link
Contributor

@chiragjn chiragjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO for future: Rename ner_v1/detectors/textual/name/hindi_const.py to ner_v1/detectors/textual/name/lang_const.py and add ignore long line lint for this file

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #385 (7003e4a) into master (e850e1c) will increase coverage by 0.00%.
The diff coverage is 94.79%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files          76       78    +2     
  Lines        5749     5777   +28     
=======================================
+ Hits         4093     4113   +20     
- Misses       1656     1664    +8     
Impacted Files Coverage Δ
ner_v1/detectors/textual/name/name_detection.py 80.54% <88.88%> (-5.64%) ⬇️
lib/nlp/spacy_utils.py 94.44% <94.44%> (ø)
lib/nlp/tests/test_nlp_utils.py 100.00% <100.00%> (ø)
ner_v1/detectors/textual/name/hindi_const.py 100.00% <100.00%> (ø)
...etectors/textual/name/tests/test_name_detection.py 100.00% <100.00%> (ø)
..._v2/detectors/textual/tests/test_elastic_search.py 100.00% <100.00%> (ø)
ner_v2/detectors/textual/tests/test_queries.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e850e1c...7003e4a. Read the comment docs.

@ashutoshsingh0223 ashutoshsingh0223 merged commit 58247d9 into master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
miscellaneous new-feature Added new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants