-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Langauge support for person name #385
Conversation
…ords for person_name
Spacy stuff
…lohaptik/chatbot_ner into Language_support_person_name
….TestESDataStore.test_add_query to use env variables
… get_hindi_text_from_regex
…lohaptik/chatbot_ner into Language_support_person_name
Language support person name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO for future: Rename ner_v1/detectors/textual/name/hindi_const.py
to ner_v1/detectors/textual/name/lang_const.py
and add ignore long line lint for this file
UNIT TESTS HAVE PASSED... Good To Merge |
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
=======================================
Coverage 71.19% 71.19%
=======================================
Files 76 78 +2
Lines 5749 5777 +28
=======================================
+ Hits 4093 4113 +20
- Misses 1656 1664 +8
Continue to review full report at Codecov.
|
JIRA Ticket Number
JIRA TICKET: https://hello-haptik.atlassian.net/browse/ML-2048
Description of change
Checklist (OPTIONAL):