Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): Upgrade django,requests,numpy,pandas,pytz,boto* and their dependencies #437

Merged
merged 13 commits into from
Oct 13, 2021
Merged

build(deps): Upgrade django,requests,numpy,pandas,pytz,boto* and their dependencies #437

merged 13 commits into from
Oct 13, 2021

Conversation

chiragjn
Copy link
Contributor

@chiragjn chiragjn commented Sep 20, 2021 •
edited
Loading

Closes #398
Closes #403
Closes #406
Closes #407
Closes #408
Closes #409
Closes #412
Closes #413
Closes #414
Closes #415
Closes #438

JIRA Ticket Number

JIRA TICKET: IS-153, ML-2730

Description of change

  • Upgrades django, requests, pytz, boto*, numpy, pandas and few other minor libraries for security fixes
  • Overhaul Dockerfile, rename Dockerfile-python3 to Dockerfile
  • Renames config.example to .env.example
  • Drops s3 dependency for nginx config files

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

haptik-deployment
haptik-deployment reviewed Sep 20, 2021
View reviewed changes
chatbot_ner/settings.py Show resolved Hide resolved
chatbot_ner/asgi.py Show resolved Hide resolved
@haptik-deployment
Copy link

👍 No lint errors found.

@chiragjn chiragjn changed the base branch from removed_unused_crf_code to develop September 20, 2021 08:25
@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Sep 20, 2021 •
edited
Loading

Codecov Report

Merging #437 (4876edf) into develop (ef5c66f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #437   +/-   ##
========================================
  Coverage    41.96%   41.96%           
========================================
  Files           79       79           
  Lines         8869     8869           
========================================
  Hits          3722     3722           
  Misses        5147     5147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5c66f...4876edf. Read the comment docs.

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@chiragjn chiragjn changed the title [WIP] build(deps): Upgrade django,requests,numpy,pandas,pytz,boto* and their dependencies build(deps): Upgrade django,requests,numpy,pandas,pytz,boto* and their dependencies Sep 21, 2021
@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

tanaya-b
tanaya-b suggested changes Oct 13, 2021
View reviewed changes
docs/datastore_variables.md Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
chatbot_ner/settings.py Outdated Show resolved Hide resolved
docker/default.nginx.conf Outdated Show resolved Hide resolved
@haptik-deployment
Copy link

👍 No lint errors found.

tanaya-b
tanaya-b previously approved these changes Oct 13, 2021
View reviewed changes
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chiragjn chiragjn requested a review from tanaya-b October 13, 2021 09:58
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@chiragjn chiragjn merged commit 4a5d366 into develop Oct 13, 2021
@chiragjn chiragjn mentioned this pull request Oct 13, 2021
Merged
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haptik-deployment haptik-deployment haptik-deployment left review comments

@tanaya-b tanaya-b tanaya-b approved these changes

Assignees
No one assigned
Labels
bug-fixes enhancement miscellaneous missing-tests No lint errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CVE-2019-11324 (High) detected in urllib3-1.23-py2.py3-none-any.whl, urllib3-1.21.1-py2.py3-none-any.whl CVE-2019-11236 (Medium) detected in urllib3-1.23-py2.py3-none-any.whl, urllib3-1.21.1-py2.py3-none-any.whl CVE-2019-6446 (High) detected in numpy-1.16.0-cp27-cp27mu-manylinux1_x86_64.whl CVE-2019-9740 (Medium) detected in urllib3-1.23-py2.py3-none-any.whl, urllib3-1.21.1-py2.py3-none-any.whl CVE-2020-26137 (Medium) detected in multiple libraries
CVE-2021-3281 (Medium) detected in Django-1.11.29-py2.py3-none-any.whl - autoclosed CVE-2020-13254 (Medium) detected in Django-1.11.29-py2.py3-none-any.whl - autoclosed CVE-2020-13596 (Medium) detected in Django-1.11.29-py2.py3-none-any.whl - autoclosed CVE-2018-20060 (High) detected in urllib3-1.21.1-py2.py3-none-any.whl CVE-2020-13091 (High) detected in pandas-0.19.0-cp27-cp27mu-manylinux1_x86_64.whl
4 participants
@chiragjn @haptik-deployment @tanaya-b @saumilhaptik