-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build support for Person Name for Newer Languages #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [ipython](https://github.com/ipython/ipython) from 7.16.1 to 7.16.3. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@7.16.1...7.16.3) --- updated-dependencies: - dependency-name: ipython dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump ipython from 7.16.1 to 7.16.3
Bumps [django](https://github.com/django/django) from 3.2.7 to 3.2.11. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.2.7...3.2.11) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump django from 3.2.7 to 3.2.11
…rch_entity_values` or sort by values ascending if `get_entity_unique_values` is not called
…_entity_name` for determinism
Bumps [django](https://github.com/django/django) from 3.2.11 to 3.2.12. - [Release notes](https://github.com/django/django/releases) - [Commits](django/django@3.2.11...3.2.12) --- updated-dependencies: - dependency-name: django dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump django from 3.2.11 to 3.2.12
…hub.com/hellohaptik/chatbot_ner into cj_fix_determinism_search_entity_values
…tity_values Make results from `external_api.lib.dictionary_utils.search_entity_values` deterministic
…emory Temporary fix till we figure out the fastest and safest way to migrate mappings
fix: revert sorting on elasticsearch side for crf data and do it in memory
Update Language constants for 7 Languages
There are 85 errors:
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
UNIT TESTS HAVE PASSED... Good To Merge |
krupalmodi18
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build support for Person Name for Newer Languages
Jira ticket : ML-2949
Lint errors : some sentences are super long, so can't be split
Duplication errors : That's why we read the dictionary value as a set. Because duplicates are present in our input data and it's difficult to go over so many languages half of which are not understandeable.