Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build support for Person Name for Newer Languages #473

Merged
merged 17 commits into from
Mar 24, 2022
Merged

Conversation

adisri2694
Copy link
Contributor

@adisri2694 adisri2694 commented Mar 17, 2022

Build support for Person Name for Newer Languages
Jira ticket : ML-2949

Lint errors : some sentences are super long, so can't be split
Duplication errors : That's why we read the dictionary value as a set. Because duplicates are present in our input data and it's difficult to go over so many languages half of which are not understandeable.

dependabot bot and others added 17 commits January 21, 2022 18:59
Bumps [ipython](https://github.com/ipython/ipython) from 7.16.1 to 7.16.3.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@7.16.1...7.16.3)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump ipython from 7.16.1 to 7.16.3
Bumps [django](https://github.com/django/django) from 3.2.7 to 3.2.11.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.7...3.2.11)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump django from 3.2.7 to 3.2.11
…rch_entity_values`

or sort by values ascending if `get_entity_unique_values` is not called
Bumps [django](https://github.com/django/django) from 3.2.11 to 3.2.12.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.11...3.2.12)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
build(deps): bump django from 3.2.11 to 3.2.12
…tity_values

Make results from `external_api.lib.dictionary_utils.search_entity_values` deterministic
…emory

Temporary fix till we figure out the fastest and safest way to  migrate mappings
fix: revert sorting on elasticsearch side for crf data and do it in memory
Update Language constants for 7 Languages
@haptik-deployment
Copy link

There are 85 errors:

  • language_utilities/constant.py, line 26 - E225 missing whitespace around operator
  • ner_v1/detectors/textual/name/lang_constants.py, line 1321 - E501 line too long (153 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1323 - E501 line too long (157 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1326 - E501 line too long (162 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1327 - E501 line too long (166 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1328 - E501 line too long (166 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1330 - E501 line too long (124 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1331 - E501 line too long (124 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1338 - E501 line too long (174 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1342 - E501 line too long (146 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1344 - E501 line too long (122 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1354 - E501 line too long (142 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1359 - E501 line too long (129 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1361 - E501 line too long (213 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1370 - E501 line too long (122 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1421 - E501 line too long (216 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1432 - E501 line too long (121 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1434 - E501 line too long (144 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1436 - E501 line too long (154 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1437 - E501 line too long (164 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1438 - E501 line too long (200 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1447 - E501 line too long (184 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1451 - E501 line too long (152 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1460 - E501 line too long (124 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1466 - E501 line too long (190 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1488 - E501 line too long (138 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1490 - E501 line too long (161 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1493 - E501 line too long (166 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1494 - E501 line too long (164 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1495 - E501 line too long (211 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1504 - E501 line too long (172 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1508 - E501 line too long (137 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1520 - E501 line too long (132 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1525 - E501 line too long (124 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1527 - E501 line too long (179 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1536 - E501 line too long (125 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1547 - E501 line too long (122 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1549 - E501 line too long (145 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1551 - E501 line too long (155 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1552 - E501 line too long (165 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1553 - E501 line too long (201 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1562 - E501 line too long (185 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1566 - E501 line too long (153 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1575 - E501 line too long (125 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1582 - E501 line too long (191 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1602 - E501 line too long (132 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1604 - E501 line too long (156 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1607 - E501 line too long (141 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1608 - E501 line too long (168 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1609 - E501 line too long (203 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1618 - E501 line too long (184 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1632 - E501 line too long (143 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1638 - E501 line too long (184 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1647 - E501 line too long (139 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1652 - E501 line too long (126 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1656 - E501 line too long (143 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1662 - E501 line too long (151 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1664 - E501 line too long (165 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1667 - E501 line too long (206 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1668 - E501 line too long (206 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1669 - E501 line too long (279 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1671 - E501 line too long (123 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1672 - E501 line too long (123 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1679 - E501 line too long (253 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1682 - E501 line too long (123 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1683 - E501 line too long (123 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1684 - E501 line too long (203 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1686 - E501 line too long (125 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1687 - E501 line too long (130 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1696 - E501 line too long (171 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1702 - E501 line too long (159 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1704 - E501 line too long (211 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1716 - E501 line too long (126 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1724 - E501 line too long (125 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1728 - E501 line too long (128 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1730 - E501 line too long (165 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1733 - E501 line too long (162 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1734 - E501 line too long (173 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1735 - E501 line too long (202 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1744 - E501 line too long (168 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1748 - E501 line too long (155 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1761 - E501 line too long (160 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1766 - E501 line too long (137 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1768 - E501 line too long (195 > 119 characters)
  • ner_v1/detectors/textual/name/lang_constants.py, line 1778 - E501 line too long (140 > 119 characters)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.5% 9.5% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@adisri2694 adisri2694 requested review from chiragjn and tanaya-b March 17, 2022 11:05
@adisri2694 adisri2694 merged commit 82aecba into master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants