Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to Master 21-04-22 #478

Merged
merged 17 commits into from
Apr 21, 2022
Merged

Develop to Master 21-04-22 #478

merged 17 commits into from
Apr 21, 2022

Conversation

tanaya-b
Copy link
Contributor

haptik-deployment
haptik-deployment reviewed Apr 21, 2022
View reviewed changes
lib/nlp/text_normalization.py
input_text (str): modified text

Example:
fit_text_to_format(input_text='1 2 3 45', regex_pattern='\d{5}')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W605 invalid escape sequence '\d'

lib/nlp/text_normalization.py

if not insert_edits:
# A rough heuristic to allow (#_of_punctuations + 2) extra characters during fuzzy matching
count = lambda l1, l2: sum([1 for x in l1 if x in l2]) # pylint: disable=E731
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E731 do not assign a lambda expression, use a def

lib/nlp/text_normalization.py

Example procedure:
input_text = "बी nine nine three zero"
regex = r"\w\d{4}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W605 invalid escape sequence '\w'
W605 invalid escape sequence '\d'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@tanaya-b tanaya-b requested a review from naseem-shaik April 21, 2022 09:31
@tanaya-b tanaya-b merged commit 999094f into master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haptik-deployment haptik-deployment haptik-deployment left review comments

@naseem-shaik naseem-shaik naseem-shaik approved these changes

Assignees
No one assigned
Labels
enhancement miscellaneous new-feature Added new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanaya-b @haptik-deployment @naseem-shaik