Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ml 3334/chinese number mapping of digits #511

Merged
merged 9 commits into from
Nov 10, 2022

Conversation

harjinder7
Copy link
Contributor

JIRA Ticket Number

JIRA TICKET: ML-3334

Description of change

Chinese number detection digit by digit

@harjinder7 harjinder7 added enhancement new-feature Added new functionality labels Nov 2, 2022
@harjinder7 harjinder7 requested review from naseem-shaik and a team November 2, 2022 03:12
ner_v2/detectors/numeral/number/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

ner_v2/api.py Outdated Show resolved Hide resolved
ner_v2/api.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
ner_v2/detectors/numeral/number/zh-TW/number_detection.py Outdated Show resolved Hide resolved
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

Copy link
Contributor

@naseem-shaik naseem-shaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harjinder7 harjinder7 merged commit 348afc3 into develop Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants