Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hinglish support for person name entity #528

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

naseem-shaik
Copy link
Contributor

JIRA Ticket Number

JIRA TICKET: ML-3504

Description of change

Hinglish support for person name entity, added some more attributes.

@naseem-shaik naseem-shaik added the new-feature Added new functionality label Feb 21, 2023
@naseem-shaik naseem-shaik requested a review from a team February 21, 2023 10:47
harjinder7
harjinder7 previously approved these changes Feb 21, 2023
Copy link
Contributor

@harjinder7 harjinder7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plz fix the lint errors

@haptik-deployment
Copy link

👍 No lint errors found.

harjinder7
harjinder7 previously approved these changes Feb 21, 2023
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

1 similar comment
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@naseem-shaik naseem-shaik merged commit 50a3021 into develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants