NER new setup instructions documentation #533
Conversation
|
👍 No lint errors found. |
|
UNIT TESTS HAVE PASSED... Good To Merge |
|
👍 No lint errors found. |
There was a problem hiding this comment.
Move the files outside the docker folder after verifying if there is any reason why we need to keep them inside and copy them out again.
Review the documentation for minor errors. (link to notion etc)
- Review and launch
- Update the bot calibrator with the latest develop pull
- Share with the engineering team steps on how to update and redeploy if needed.
|
👍 No lint errors found. |
| EXPOSE 8081 | ||
| ADD . /app | ||
| RUN chmod +x /app/entrypoint.sh | ||
| CMD /app/entrypoint.sh |
There was a problem hiding this comment.
Rename the entrypoint.sh file or confirm with Jaspreet that it won't cause name conflict on staging or production.
There was a problem hiding this comment.
Confirmed with Jaspreet, there won't be no conflict on staging and prod.
|
👍 No lint errors found. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Unit test case pass during dev testing
|
There was a problem hiding this comment.
We have removed docker folder from NER setup. As per devops the NER setup file for Staging and prod are getting downloaded from S3 so there no need of these files anymore. Also we ran unit testcases and entity testing suite on these changes and it got passed successfully hence approving the PR
There was a problem hiding this comment.
We have removed docker folder from NER setup. As per devops the NER setup file for Staging and prod are getting downloaded from S3 so there no need of these files anymore. Also we ran unit testcases and entity testing suite on these changes and it got passed successfully hence approving the PR
JIRA Ticket Number
JIRA TICKET: ML-3625
Description of change
Documentation for setting up NER in dev is added. Instructions are mention how to setup NER with help of docker and setup elastic-search for entities.