Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logs for training flow #543

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

rootAvish
Copy link
Contributor

@rootAvish rootAvish commented Jul 29, 2023

JIRA Ticket Number

JIRA TICKET: ML-3692

Description of change

Adds a few debug logs for requests to bulk endpoint.

Checklist (OPTIONAL):

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@haptik-deployment
Copy link

👍 No lint errors found.

@haptik-deployment
Copy link

👍 No lint errors found.

@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (dd9704c) 40.49% compared to head (f2046c8) 40.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #543      +/-   ##
===========================================
- Coverage    40.49%   40.46%   -0.04%     
===========================================
  Files           81       81              
  Lines         9434     9441       +7     
===========================================
  Hits          3820     3820              
- Misses        5614     5621       +7     
Files Changed Coverage Δ
ner_v1/api.py 22.12% <0.00%> (-0.49%) ⬇️
ner_v1/chatbot/entity_detection.py 21.34% <0.00%> (-0.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rootAvish rootAvish changed the title Logging changes for training flow Add debug logs for training flow Jul 29, 2023
@haptik-deployment
Copy link

UNIT TESTS HAVE PASSED... Good To Merge

Copy link
Contributor

@HiteshC6595 HiteshC6595 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Training flow is working as expected along with inference hence approving the PR

Testing bot - entitytestingbottool, test bot dialogue policy

Entity detection flow is working as expected

@rootAvish rootAvish merged commit 37e373a into develop Jul 31, 2023
4 of 6 checks passed
@ganeshhaptik ganeshhaptik mentioned this pull request Oct 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants